Skip to content

Add licenses to temporal_capi and temporal_rs for publish #247

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 20, 2025

Conversation

nekevss
Copy link
Member

@nekevss nekevss commented Mar 19, 2025

This PR adds the license files to the published package.

Licenses were copied into temporal_capi to hopefully work around an issue with including licenses when publishing workspace packages in cargo.

CC: @Manishearth, in case you have any feedback.

@nekevss nekevss requested a review from jedel1043 March 19, 2025 23:13
@nekevss nekevss added the C-internal Internal library improvements label Mar 19, 2025
Copy link
Contributor

@Manishearth Manishearth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

probably want

@@ -12,6 +12,7 @@ include = [
"src/**/*",
"tests/**/*",
"Cargo.toml",
"LICENSE*",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this doesn't do anything, LICENSE doesn't exist.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I explicitly listed the license filenames then. I'm assuming that should then include them

@nekevss nekevss merged commit 7306387 into main Mar 20, 2025
8 checks passed
@nekevss nekevss deleted the include-license branch March 20, 2025 01:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-internal Internal library improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants