Add licenses to temporal_capi and temporal_rs for publish
#247
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Manishearth
reviewed
Mar 20, 2025
temporal_capi/Cargo.toml
Outdated
| @@ -12,6 +12,7 @@ include = [ | |||
| "src/**/*", | |||
| "tests/**/*", | |||
| "Cargo.toml", | |||
| "LICENSE*", | |||
There was a problem hiding this comment.
this doesn't do anything, LICENSE doesn't exist.
There was a problem hiding this comment.
I explicitly listed the license filenames then. I'm assuming that should then include them
Manishearth
approved these changes
Mar 20, 2025
jedel1043
approved these changes
Mar 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the license files to the published package.
Licenses were copied into
temporal_capito hopefully work around an issue with including licenses when publishing workspace packages in cargo.CC: @Manishearth, in case you have any feedback.