feat: add pnpm completion script #23
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
commit: |
Aslemammad
reviewed
Apr 12, 2025
|
AmirSa12
force-pushed
the
feat/pnpm-script
branch
from
03e52e5 to
07acf01
Compare
dreyfus92
reviewed
Apr 30, 2025
Comment on lines
+118
to
+143
| case $state in | ||
| filter) | ||
| if [[ -f ./pnpm-workspace.yaml ]] && [[ -x "$pnpm_comp_bin" ]]; then | ||
| _pnpm_tab_debug "Using pnpm-shell-completion for filter packages" | ||
| _values 'filter packages' $(FEATURE=filter $pnpm_comp_bin) | ||
| else | ||
| _pnpm_tab_debug "No workspace or pnpm-shell-completion for filter" | ||
| _message "package filter" | ||
| fi | ||
| ;; | ||
| scripts) | ||
| if [[ -x "$pnpm_comp_bin" ]]; then | ||
| _pnpm_tab_debug "Using pnpm-shell-completion for scripts" | ||
| _values 'scripts' $(FEATURE=scripts TARGET_PKG=$target_pkg ZSH=true $pnpm_comp_bin) \ | ||
| add remove install update publish | ||
| else | ||
| _pnpm_tab_debug "Using basic pnpm commands (no pnpm-shell-completion)" | ||
| _values 'scripts' \ | ||
| 'add:Add a dependency' \ | ||
| 'install:Install dependencies' \ | ||
| 'remove:Remove a dependency' \ | ||
| 'update:Update dependencies' \ | ||
| 'publish:Publish package' \ | ||
| 'run:Run script' | ||
| fi | ||
| ;; |
There was a problem hiding this comment.
i'm just throwing an idea here, but dunno if you explored the possibility of having a caching utility, then use it within the filter completion case to use the cache and finally clean that cache file when the script exits.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.