Sami Saeed #130
Open
Sami Saeed #130
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -0,0 +1,3 @@ | |||
| { | |||
| "liveServer.settings.port": 5502 | |||
There was a problem hiding this comment.
no need to commit this file :)
Comment on lines
+74
to
+78
| .username ul li a span { | ||
| position: relative; | ||
| left: 8px; | ||
| bottom: 10px; | ||
| } |
There was a problem hiding this comment.
This doesn't select anything, try to go over your other rules and find some that can be deleted
| padding-bottom: 0; | ||
| } | ||
|
|
||
| .menu { |
There was a problem hiding this comment.
You can look into CSS nesting to write more concise rules
| font-family: "Gill Sans", "Gill Sans MT", Calibri, "Trebuchet MS", sans-serif; | ||
| } | ||
|
|
||
| .left-music ul li a span { |
There was a problem hiding this comment.
You often used very complex selectors to get nested items. My recommendation is that you use more CSS classes instead, to have more easy-to-read and concise rules.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.