-
Notifications
You must be signed in to change notification settings - Fork 159
Sami Saeed #156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Sami Saeed #156
Conversation
} | ||
.logo{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You should add an empty line after every CSS block to give some breathing space, it makes it a little easier to read / maintain
img{ | ||
height:40px; | ||
width:47px; | ||
padding-left:5px | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is this img
element inside of the logo
element? You can't nest css selectors inside of others, except with things like media queries. You should use specificity to target specific child elements:
.logo img {
}
img{ | ||
height: 25px; | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same here, you can't nest this img element inside the home-btn element
<link rel="stylesheet" href="./new_twitter.css" /> | ||
</head> | ||
<body> | ||
<div class = 'container'> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't add white space around the property/value pairs. It works, but it goes against convention - I don't know any project that uses whitespace in this way. Also, be sure to use double quotes instead of single quotes
<div class="container">
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good work! Be careful with nesting CSS selectors inside of other CSS selectors
No description provided.