Skip to content

Sami Saeed #156

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Sami Saeed #156

wants to merge 2 commits into from

Conversation

samisalehsaeed
Copy link

No description provided.

Comment on lines +9 to +10
}
.logo{
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should add an empty line after every CSS block to give some breathing space, it makes it a little easier to read / maintain

Comment on lines +11 to +15
img{
height:40px;
width:47px;
padding-left:5px
}
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this img element inside of the logo element? You can't nest css selectors inside of others, except with things like media queries. You should use specificity to target specific child elements:

.logo img {

}

Comment on lines +41 to +43
img{
height: 25px;
}
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here, you can't nest this img element inside the home-btn element

<link rel="stylesheet" href="./new_twitter.css" />
</head>
<body>
<div class = 'container'>
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't add white space around the property/value pairs. It works, but it goes against convention - I don't know any project that uses whitespace in this way. Also, be sure to use double quotes instead of single quotes

<div class="container">

Copy link

@vherus vherus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work! Be careful with nesting CSS selectors inside of other CSS selectors

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants