Skip to content

Oluwagbemi Abiodun #168

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Oluwagbemi Abiodun #168

wants to merge 2 commits into from

Conversation

Alakowe19
Copy link

No description provided.

Comment on lines +17 to +23
<div class="sidebar">
<i class="fab fa-twitter"></i>

<div class="sidebarOption active">
<span class="material-icons"> home </span>
<h2>Home</h2>
</div>
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your indentation is a little off, I'm not sure where one div ends and another begins. This would be easier to maintain like this:

    <div class="sidebar">
        <i class="fab fa-twitter"></i>

        <div class="sidebarOption active">
            <span class="material-icons"> home </span>
            <h2>Home</h2>
        </div>



<!-- I start buiding my post section here -->
<div class="post">
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this div should be floating all the way at the left side of the file

Copy link

@vherus vherus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work. Your indentation needs a bit of work to improve its consistency and quality, and your css should be using kebab-case instead of camelCase. Keep up the great work :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants