Adding Median absolute deviation, #4 #24
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boristane
requested changes
Jan 4, 2019
| @@ -332,6 +333,7 @@ These methods compute a measure of the variability in a sample or population, ho | |||
| - [pStdev](#pStdev): Population standard deviation | |||
| - [variance](#variance): Sample variance | |||
| - [stdev](#stdev): Sample standard deviation | |||
| - [medAbsdev](#medAbsdev): Median absolute deviation | |||
There was a problem hiding this comment.
Can you please rename this method to mad throughout all files?
| export function medAbsdev(arr) { | ||
| const med = median(arr); | ||
| const absoluteDeviationArr = []; | ||
| if (med === undefined) return undefined; |
There was a problem hiding this comment.
This can go above the previous line. It is not necessary to declare absoluteDeviationArr before checking if the median is undefined.
| const absoluteDeviationArr = []; | ||
| if (med === undefined) return undefined; | ||
| for (let i = 0; i < arr.length; i += 1) { | ||
| const absdev = Math.abs(arr[i] - med); |
There was a problem hiding this comment.
Please be consistent with variable naming and use camelCase. Following the previously defined array absoluteDeviationArr this would be absoluteDeviation.
In this case, absoluteDeviationArr could even be renamed to absoluteDeviations. I leave this to your discretion.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.