Disable checking file name and erroring for shared gdrive files. #518

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

jpolitz merged 1 commit into brownplt:horizon from asolove:asolove/name-mismatch

Mar 13, 2025

Contributor

asolove commented Mar 14, 2024

This is a minimal version of fixing #517.

Whether this is a good idea or not is outside of my ability to judge.

Even if this is a good idea at a high level, there are two other things we might want to do:

Make the filename itself optional, so it's just not needed.
Update the source code of the current file to reflect the new name. This would prevent confusion but also introduces a surprising information leak if the file is renamed without the new name being safe to share.


          Disable checking file name and erroring for shared gdrive files.

a5b9a60

Member

jpolitz commented Mar 13, 2025

Yeah this is a good idea, thanks, sorry it got lost for a while.

jpolitz merged commit 63d689d into brownplt:horizon

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet