Fix recv_uninit to handle the TRUNC flag.
#1159
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With the `TRUNC` flag, `recv` returns the untruncated length, which may be longer than the provided buffer. Fix `recv_uninit` and `recvfrom_uninit` to handle this case. This mean that `recv_uninit` and `recvfrom_uninit` are unable to return the full untruncated length returned by `recv` with the `TRUNC` flag, however it appears that fixing that may require API changes. Fixes #1153.
sunfishcode
added a commit
that referenced
this pull request
Sep 11, 2024
* Fix `recv_uninit` to handle the `TRUNC` flag. With the `TRUNC` flag, `recv` returns the untruncated length, which may be longer than the provided buffer. Fix `recv_uninit` and `recvfrom_uninit` to handle this case. This mean that `recv_uninit` and `recvfrom_uninit` are unable to return the full untruncated length returned by `recv` with the `TRUNC` flag, however it appears that fixing that may require API changes. Fixes #1153. * Add comments mentioning alternatives.
sunfishcode
added a commit
that referenced
this pull request
Sep 11, 2024
* Fix `recv_uninit` to handle the `TRUNC` flag. With the `TRUNC` flag, `recv` returns the untruncated length, which may be longer than the provided buffer. Fix `recv_uninit` and `recvfrom_uninit` to handle this case. This mean that `recv_uninit` and `recvfrom_uninit` are unable to return the full untruncated length returned by `recv` with the `TRUNC` flag, however it appears that fixing that may require API changes. Fixes #1153. * Add comments mentioning alternatives.
sunfishcode
added a commit
that referenced
this pull request
Jan 23, 2025
…init`. As discussed in #1159, add a length to the return value of `recv_uninit` and `recvfrom_uninit` to report the original received length, which with `RecvFlags::TRUNC` may differ from the returned buffer length.
sunfishcode
added a commit
that referenced
this pull request
Jan 30, 2025
…init`. As discussed in #1159, add a length to the return value of `recv_uninit` and `recvfrom_uninit` to report the original received length, which with `RecvFlags::TRUNC` may differ from the returned buffer length.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the
TRUNCflag,recvreturns the untruncated length, which may be longer than the provided buffer. Fixrecv_uninitandrecvfrom_uninitto handle this case.This mean that
recv_uninitandrecvfrom_uninitare unable to return the full untruncated length returned byrecvwith theTRUNCflag, however it appears that fixing that may require API changes.Fixes #1153.