Add serialize to all the exported structs of wit-parser #1177

Mossaka · 2023-08-23T08:25:14Z

This PR adds Serialize implementation to all the exported structs of the wit-parser crate so that it could output JSON given a WIT package.

This follows the discussion from bytecodealliance/wit-bindgen#640

Since wit-parser uses id-arena for allocating graph objects, which doesn't support serde, I had to fork this project and added Serialize to Id and Arena. See here for my changes: fitzgen/id-arena#14

Usage:

wasm-tools component wit --json

Example Output

Give the following WIT

package foo:foo

interface disambiguate {
  type t = u32
}

world foo {
  type a = u32

  type b = a

  export c: func(a: a) -> b
}
world bar {
  import disambiguate
  use disambiguate.{t}

  export foo: func() -> t
}
world the-test {
  import foo: func(a: a) -> b

  record a {
    x: u32,
  }

  variant b {
    c(a),
  }

  export bar: func(a: a) -> b
}

The corresponding JSON format is

{
  "worlds": [
    {
      "name": "foo",
      "docs": {
        "contents": null
      },
      "imports": {
        "a": {
          "Type": "type-1"
        },
        "b": {
          "Type": "type-2"
        }
      },
      "exports": {
        "c": {
          "Function": {
            "docs": {
              "contents": null
            },
            "name": "c",
            "kind": "Freestanding",
            "params": [
              [
                "a",
                "type-1"
              ]
            ],
            "results": {
              "Anon": "type-2"
            }
          }
        }
      },
      "package": {
        "idx": 0
      }
    },
    {
      "name": "bar",
      "docs": {
        "contents": null
      },
      "imports": {
        "interface-0": {
          "Interface": "interface-0"
        },
        "t": {
          "Type": "type-3"
        }
      },
      "exports": {
        "foo": {
          "Function": {
            "docs": {
              "contents": null
            },
            "name": "foo",
            "kind": "Freestanding",
            "params": [],
            "results": {
              "Anon": "type-3"
            }
          }
        }
      },
      "package": {
        "idx": 0
      }
    },
    {
      "name": "the-test",
      "docs": {
        "contents": null
      },
      "imports": {
        "a": {
          "Type": "type-4"
        },
        "b": {
          "Type": "type-5"
        },
        "foo": {
          "Function": {
            "docs": {
              "contents": null
            },
            "name": "foo",
            "kind": "Freestanding",
            "params": [
              [
                "a",
                "type-4"
              ]
            ],
            "results": {
              "Anon": "type-5"
            }
          }
        }
      },
      "exports": {
        "bar": {
          "Function": {
            "docs": {
              "contents": null
            },
            "name": "bar",
            "kind": "Freestanding",
            "params": [
              [
                "a",
                "type-4"
              ]
            ],
            "results": {
              "Anon": "type-5"
            }
          }
        }
      },
      "package": {
        "idx": 0
      }
    }
  ],
  "interfaces": [
    {
      "name": "disambiguate",
      "docs": {
        "contents": null
      },
      "types": {
        "t": {
          "idx": 0
        }
      },
      "functions": {},
      "package": {
        "idx": 0
      }
    }
  ],
  "types": [
    {
      "docs": {
        "contents": null
      },
      "kind": {
        "Type": "U32"
      },
      "name": "t",
      "owner": {
        "Interface": {
          "idx": 0
        }
      }
    },
    {
      "docs": {
        "contents": null
      },
      "kind": {
        "Type": "U32"
      },
      "name": "a",
      "owner": {
        "World": {
          "idx": 0
        }
      }
    },
    {
      "docs": {
        "contents": null
      },
      "kind": {
        "Type": "type-1"
      },
      "name": "b",
      "owner": {
        "World": {
          "idx": 0
        }
      }
    },
    {
      "docs": {
        "contents": null
      },
      "kind": {
        "Type": "type-0"
      },
      "name": "t",
      "owner": {
        "World": {
          "idx": 1
        }
      }
    },
    {
      "docs": {
        "contents": null
      },
      "kind": {
        "Record": {
          "fields": [
            {
              "docs": {
                "contents": null
              },
              "name": "x",
              "ty": "U32"
            }
          ]
        }
      },
      "name": "a",
      "owner": {
        "World": {
          "idx": 2
        }
      }
    },
    {
      "docs": {
        "contents": null
      },
      "kind": {
        "Variant": {
          "cases": [
            {
              "docs": {
                "contents": null
              },
              "name": "c",
              "ty": "type-4"
            }
          ]
        }
      },
      "name": "b",
      "owner": {
        "World": {
          "idx": 2
        }
      }
    }
  ],
  "packages": [
    {
      "name": "foo:foo",
      "docs": {
        "contents": null
      },
      "interfaces": {
        "disambiguate": {
          "idx": 0
        }
      },
      "worlds": {
        "foo": {
          "idx": 0
        },
        "bar": {
          "idx": 1
        },
        "the-test": {
          "idx": 2
        }
      }
    }
  ],
  "package_names": {
    "foo:foo": {
      "idx": 0
    }
  }
}

alexcrichton · 2023-08-23T19:33:52Z

Would it be possible to avoid the need for id-arena to be Serialize/Deserialize? That includes the arena_id in a number of places which is irrelevant for this representation. On one hand I realize that this PR amounts to "let's just dump the internal representation" but at the same time if we can I think it'd be best to do our best to hide the Rust-specific bits that aren't relevant elsewhere.

Mossaka · 2023-08-23T22:23:51Z

Would it be possible to avoid the need for id-arena to be Serialize/Deserialize?

I believe arena_id could be omitted from the output, but idx is a key for looking for types, interfaces, worlds and packages.

Mossaka · 2023-08-23T22:24:43Z

to hide the Rust-specific bits that aren't relevant elsewhere.

What do you consider are Rust-specific bits?

alexcrichton · 2023-08-24T14:24:02Z

Yes idx is required but the arena bits are the Rust-specific bits I'm worried about. Other Rust-specific bits could perhaps be serialized enum representations but that depends on the output.

Mossaka · 2023-09-03T03:09:25Z

Just updated the repo thanks to @ydnar . Now the JSON output looks like

{
  "worlds": [
    {
      "name": "foo",
      "docs": {
        "contents": null
      },
      "imports": {
        "a": {
          "type": 1
        },
        "b": {
          "type": 2
        }
      },
      "exports": {
        "c": {
          "function": {
            "docs": {
              "contents": null
            },
            "name": "c",
            "kind": "freestanding",
            "params": [
              {
                "name": "a",
                "type": 1
              }
            ],
            "results": [
              {
                "type": 2
              }
            ]
          }
        }
      },
      "package": 0
    },
    {
      "name": "bar",
      "docs": {
        "contents": null
      },
      "imports": {
        "interface-0": {
          "interface": 0
        },
        "t": {
          "type": 3
        }
      },
      "exports": {
        "foo": {
          "function": {
            "docs": {
              "contents": null
            },
            "name": "foo",
            "kind": "freestanding",
            "params": [],
            "results": [
              {
                "type": 3
              }
            ]
          }
        }
      },
      "package": 0
    },
    {
      "name": "the-test",
      "docs": {
        "contents": null
      },
      "imports": {
        "a": {
          "type": 4
        },
        "b": {
          "type": 5
        },
        "foo": {
          "function": {
            "docs": {
              "contents": null
            },
            "name": "foo",
            "kind": "freestanding",
            "params": [
              {
                "name": "a",
                "type": 4
              }
            ],
            "results": [
              {
                "type": 5
              }
            ]
          }
        }
      },
      "exports": {
        "bar": {
          "function": {
            "docs": {
              "contents": null
            },
            "name": "bar",
            "kind": "freestanding",
            "params": [
              {
                "name": "a",
                "type": 4
              }
            ],
            "results": [
              {
                "type": 5
              }
            ]
          }
        }
      },
      "package": 0
    }
  ],
  "interfaces": [
    {
      "name": "disambiguate",
      "docs": {
        "contents": null
      },
      "types": {
        "t": 0
      },
      "functions": {},
      "package": 0
    }
  ],
  "types": [
    {
      "docs": {
        "contents": null
      },
      "kind": {
        "type": "u32"
      },
      "name": "t",
      "owner": {
        "interface": 0
      }
    },
    {
      "docs": {
        "contents": null
      },
      "kind": {
        "type": "u32"
      },
      "name": "a",
      "owner": {
        "world": 0
      }
    },
    {
      "docs": {
        "contents": null
      },
      "kind": {
        "type": 1
      },
      "name": "b",
      "owner": {
        "world": 0
      }
    },
    {
      "docs": {
        "contents": null
      },
      "kind": {
        "type": 0
      },
      "name": "t",
      "owner": {
        "world": 1
      }
    },
    {
      "docs": {
        "contents": null
      },
      "kind": {
        "record": {
          "fields": [
            {
              "docs": {
                "contents": null
              },
              "name": "x",
              "type": "u32"
            }
          ]
        }
      },
      "name": "a",
      "owner": {
        "world": 2
      }
    },
    {
      "docs": {
        "contents": null
      },
      "kind": {
        "variant": {
          "cases": [
            {
              "docs": {
                "contents": null
              },
              "name": "c",
              "type": 4
            }
          ]
        }
      },
      "name": "b",
      "owner": {
        "world": 2
      }
    }
  ],
  "packages": [
    {
      "name": "foo:foo",
      "docs": {
        "contents": null
      },
      "interfaces": {
        "disambiguate": 0
      },
      "worlds": {
        "foo": 0,
        "bar": 1,
        "the-test": 2
      }
    }
  ]
}

Mossaka · 2023-09-03T03:27:53Z

crates/wit-parser/src/resolve.rs

+        };
+        let s = serde_json::to_string(&resolve).unwrap();
+        let json_resolve = JSON_RESOLVE.replace(" ", "").replace("\n", "");
+        assert_eq!(s, json_resolve);


@ydnar I've added a dummy Resolve to match the JSON output

Thanks for the tests here! I'm a bit worried about the maintainability of this over time though as updating this test is going to be a bit of a pain. Alternatively though could the tests/ui/*.wit tests be all automatically serialized to JSON? Similar to how *.result files are generated for the ui/parse-fail/*.wit tests could the *.json tests be automatically generated for all the WIT successful tests? That way it'd be easy to see changes-at-a-glance and additionally auto-update test expectations when anything changes.

I think it makes sense to generate and commit golden JSON files for all the WIT files in tests/ui, and compare against these.

Sounds good. I will work on that (expecting delayed commits from me as I am attending WasmCon this week)

Just updated this PR to commit all JSON files corresponding to valid WIT files. The test runner is able to compare and emitted JSON from resolve to commited JSON files similar to how .result files work. Coud you PTAL, @alexcrichton ?

ydnar · 2023-09-03T03:35:26Z

crates/wit-parser/src/lib.rs

@@ -266,14 +285,24 @@ pub struct IncludeName {

 /// The key to the import/export maps of a world. Either a kebab-name or a
 /// unique interface.
-#[derive(Debug, Clone, PartialEq, Eq, Hash)]
+#[derive(Debug, Clone, PartialEq, Eq, Hash, Serialize)]
+#[serde(into = "String")]
 pub enum WorldKey {
    /// A kebab-name.
    Name(String),
    /// An interface which is assigned no kebab-name.
    Interface(InterfaceId),


Shoot. Forgot to make this one a JSON number like the other enums.

Looks like this is what we want, because WorldKey is used in World exports and imports IndexMap<WorldKey, WorldItem>.

cardoso · 2023-09-04T00:20:33Z

This is great! Any chance this could evolve to export span information at some point? If so, once this is merged, I'd be happy to push a draft PR and discuss further.

I had to pause bytecodealliance/vscode-wit#16 , but with this + span info, the implementation of LSP for WIT would be much more straightforward especially while the language isn't stable.

I really like the approach used here: https://github.com/dtolnay/clang-ast

The purpose here is different, but I guess a lot still applies.

alexcrichton · 2023-09-05T14:11:37Z

crates/wit-parser/src/resolve.rs

+    "worlds": [
+        {
+        "name": "world1",
+        "docs": { "contents": null },


Could docs be skipped if the contents are null?

Sure. Is there any plans to add additional fields to the Docs struct? Could it be an optional string?

I don't think there are any current plans, no, but it seemed like something which could be simplified when I was reading over this

OK, great. Maybe a different PR? PackageName notwithstanding our goal was to not change the public API of this crate.

Hm I don't think this would require a separate PR? I'm hoping to change this output in this PR by dropping the "docs": ... if it's empty. I think that can be done with #[serde(skip_if = "...")] or a similar field attribute name.

alexcrichton · 2023-09-05T14:12:00Z

Cargo.toml

@@ -134,23 +134,7 @@ harness = false

 [features]
 # By default, all subcommands are built
-default = [


Could the formatting changes in this file be undone?

alexcrichton · 2023-09-05T14:13:10Z

crates/wit-parser/src/lib.rs

 pub struct PackageName {
    /// A namespace such as `wasi` in `wasi:foo/bar`
    pub namespace: String,
    /// The kebab-name of this package, which is always specified.
    pub name: String,
    /// Optional major/minor version information.
-    pub version: Option<Version>,
+    pub version: Option<SerializableVersion>,


Instead of using SerializableVersion could this use serialize_with?

According to the tests, this works with semver::Version without SerializableVersion at all. So I removed it in be17ced.

alexcrichton · 2023-09-05T14:13:38Z

crates/wit-parser/src/lib.rs

    pub include_names: Vec<Vec<IncludeName>>,
 }

-#[derive(Debug, Clone)]
+#[derive(Debug, Clone, Serialize)]


Does this need Serialize if it's serde(skip)'d above?

alexcrichton · 2023-09-05T14:14:29Z

crates/wit-parser/src/lib.rs

+    fn from(key: WorldKey) -> String {
+        match key {
+            WorldKey::Name(name) => name,
+            WorldKey::Interface(id) => format!("interface-{}", id.index()),


This may also be what @ydnar is referring to just above this, but I think it'd be good to separate these two ariants a it better than with an interface- prefix since that looks a lot like a kebab-name

Agreed. Since this is just an internal reference to an Interface I think this can be serialized to a JSON number.

Upon further investigation, I think we need to have a unique string-serializable key for the IndexMap<WorldKey, WorldItem> maps in World, given that interfaces may be unnamed:

/// Optionally listed name of this interface. /// /// This is `None` for inline interfaces in worlds. pub name: Option<String>,

@alexcrichton are you OK with the kebab-case interface-$N form or is there another form you’d prefer?

alexcrichton · 2023-09-05T14:15:09Z

crates/wit-parser/src/lib.rs

    pub package: Option<PackageId>,
 }

-#[derive(Debug, Clone, PartialEq)]
+#[derive(Debug, Clone, PartialEq, Serialize)]
 pub struct TypeDef {
    pub docs: Docs,
    pub kind: TypeDefKind,
    pub name: Option<String>,


Could this be serde(skip)'d if the name is None?

This is done in ydnar@68b52f6

@alexcrichton would reordering some of the fields in the Resolve or child structs be a problem?

I’d like to reorganize a little, moving name above docs, for instance, so the serialization is a bit more human-readable. I’d do this in a follow-up PR.

alexcrichton · 2023-09-05T14:15:44Z

crates/wit-parser/src/lib.rs

 pub struct TypeDef {
    pub docs: Docs,
    pub kind: TypeDefKind,
    pub name: Option<String>,
    pub owner: TypeOwner,
 }

-#[derive(Debug, Clone, PartialEq)]
+#[derive(Debug, Clone, PartialEq, Serialize)]
+#[serde(rename_all = "lowercase")]


Instead of "lowercase" could "kebab-case" be used for this and all other serialization keys?

Does BA have a style guide or doc somewhere on how to represent names and identifiers? e.g. when to use kebab-case vs camel vs snake / screaming snake?

(given most target languages don’t support kebab-case for identifiers)

Heh I don't think anything is anywhere near official to have these sort of guidelines at a BA level by any means.

In any case though I figure kebab-case might be good to have since it matches the component model.

Turns out all of the fields are single words, so kebab and lowercase are identical. Revisit if/when this changes?

alexcrichton · 2023-09-05T14:19:24Z

crates/wit-parser/src/resolve.rs

+        };
+        let s = serde_json::to_string(&resolve).unwrap();
+        let json_resolve = JSON_RESOLVE.replace(" ", "").replace("\n", "");
+        assert_eq!(s, json_resolve);


Thanks for the tests here! I'm a bit worried about the maintainability of this over time though as updating this test is going to be a bit of a pain. Alternatively though could the tests/ui/*.wit tests be all automatically serialized to JSON? Similar to how *.result files are generated for the ui/parse-fail/*.wit tests could the *.json tests be automatically generated for all the WIT successful tests? That way it'd be easy to see changes-at-a-glance and additionally auto-update test expectations when anything changes.

Signed-off-by: Jiaxiao Zhou (Mossaka) <[email protected]>

1. serialize the Arena fields of Resolve as arrays, instead of an object with arena_id 2. serialize world items with kebab indexed 3. remove arena_id Signed-off-by: Jiaxiao Zhou (Mossaka) <[email protected]>

…upport

…with Deref/MutDeref This allows us to implement Serialize on the Params type.

Might change this?

This should allow wit-parser to serialize without the upstream patch to id_arena.

Handle serialization using existing type alias to not break existing public API.

…tions

Not needed?

Signed-off-by: Jiaxiao Zhou (Mossaka) <[email protected]>

This uses the "BLESS=1" env var to tell `cargo test` to force to write to files. Signed-off-by: Jiaxiao Zhou (Mossaka) <[email protected]>

Signed-off-by: Jiaxiao Zhou (Mossaka) <[email protected]>

alexcrichton

Thanks! I realize that there's still a follow-up here or there, but if you'd prefer I'd be ok landing this first and can iterate on it in-tree.

ydnar · 2023-09-14T15:22:52Z

@alexcrichton thanks! I have a couple commits to land to address feedback. Mind holding off merging until I land those?

alexcrichton · 2023-09-14T15:27:25Z

No worries, sounds good! Let me know when you're ready

ydnar · 2023-09-14T19:13:20Z

@alexcrichton @Mossaka is on holiday, so I can’t push commits to his repo (and therefore this PR).

I could open a new PR with this + my subsequent commits, if you want.

https://github.com/bytecodealliance/wasm-tools/compare/main...ydnar:wasm-tools:serde?expand=1

alexcrichton · 2023-09-14T19:21:19Z

Sounds good to me!

ydnar · 2023-09-14T19:33:20Z

@alexcrichton OK, #1203 is up!

alexcrichton · 2023-09-14T20:22:13Z

Merged as part of #1203, so closing. (thanks again!)

Mossaka marked this pull request as draft August 23, 2023 08:25

Mossaka mentioned this pull request Aug 23, 2023

feat: add support for serde fitzgen/id-arena#14

Closed

Mossaka force-pushed the serde branch from a072797 to e9639c6 Compare August 23, 2023 08:33

Mossaka force-pushed the serde branch 2 times, most recently from 99b30a8 to fbc2e95 Compare September 1, 2023 23:29

Mossaka changed the title ~~DO NOT MERGE: Add serialize to all the exported structs of wit-parser~~ Add serialize to all the exported structs of wit-parser Sep 3, 2023

Mossaka marked this pull request as ready for review September 3, 2023 03:04

Mossaka commented Sep 3, 2023

View reviewed changes

ydnar reviewed Sep 3, 2023

View reviewed changes

alexcrichton reviewed Sep 5, 2023

View reviewed changes

Mossaka and others added 14 commits September 13, 2023 20:48

add serialize to all the exported structs

fcd3242

Signed-off-by: Jiaxiao Zhou (Mossaka) <[email protected]>

rustfmt

b5b79ba

Signed-off-by: Jiaxiao Zhou (Mossaka) <[email protected]>

simplify the JSON output

8edc9f8

1. serialize the Arena fields of Resolve as arrays, instead of an object with arena_id 2. serialize world items with kebab indexed 3. remove arena_id Signed-off-by: Jiaxiao Zhou (Mossaka) <[email protected]>

wit-parser: add implementation of id_arena::ArenaBehavior for serde s…

dbdde18

…upport

wit-parser: rename world arg to world_id

7a27087

wit-parser: use InterfaceId and WorldId types

a63119a

wit-parser: skip serialization of package name index

4e3602d

wit-parser: additional Serialize implementations

3bd24fb

wit-parser: use derived Serialize for more types

48e4ad5

wit-parser: change Params type from an alias to a single-value tuple …

218d8f1

…with Deref/MutDeref This allows us to implement Serialize on the Params type.

wit-parser: cleanup on aisle params

fe3a420

wit-parser: lowercase serialization for enums

6bf12cb

Might change this?

wit-parser: implement Serialize in a function

ea455fb

This should allow wit-parser to serialize without the upstream patch to id_arena.

wit-parser: remove dependency on fork of id-arena crate

b5c68b4

ydnar and others added 18 commits September 13, 2023 20:48

wit-parser: remove custom Serialize impl for Docs

706d489

wit-parser: custom Serialize implementation for Handle and TypeOwner

9d95299

wit-parser: custom Serialize impl for WorldItem

79188fb

wit-parser: Serialize enums with less code

2fdeb0c

wit-parser: implement lowercase derived impl Serialize for FunctionKind

abd730f

wit-parser: serialize WIT types in JSON in their lowercase form

1771e10

wit-component, wit-parser: remove custom Params type

ccb7e5c

Handle serialization using existing type alias to not break existing public API.

wit-parser: remove commented-out serialize fn

52015c7

wit-parser: remove custom Serialize impl for Results

61e48b1

wit-parser: remove custom ArenaBehavior in favor of serialize_\* func…

db4b091

…tions

wit-component: revert unnecessary line change

3eff7f0

wit-parser: revert unrelated change

d49b5fb

wit-parser: remove Serialize impl from Int

5d9f368

wit-parser: remove From<Int> for String

14230bf

wit-parser: remove Serialize impl from FlagsRepr

dbf7bfd

Not needed?

fixed the tests and run rustfmt

9467869

Signed-off-by: Jiaxiao Zhou (Mossaka) <[email protected]>

add serde_json to component feature

34baa97

Signed-off-by: Jiaxiao Zhou (Mossaka) <[email protected]>

modified the tests to generate json for each valid WIT package.

db47700

This uses the "BLESS=1" env var to tell `cargo test` to force to write to files. Signed-off-by: Jiaxiao Zhou (Mossaka) <[email protected]>

Mossaka force-pushed the serde branch from dfc466e to db47700 Compare September 14, 2023 04:04

delete the unit tests in resolve.rs

9bd2309

Signed-off-by: Jiaxiao Zhou (Mossaka) <[email protected]>

alexcrichton approved these changes Sep 14, 2023

View reviewed changes

ydnar mentioned this pull request Sep 14, 2023

Add Serialize and JSON serialization support to the exported structs in wit-parser #1203

Merged

alexcrichton closed this Sep 14, 2023

Mossaka deleted the serde branch September 14, 2023 23:26

Add serialize to all the exported structs of wit-parser #1177

Add serialize to all the exported structs of wit-parser #1177

Uh oh!

Conversation

Mossaka commented Aug 23, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Usage:

Example Output

Uh oh!

alexcrichton commented Aug 23, 2023

Uh oh!

Mossaka commented Aug 23, 2023

Uh oh!

Mossaka commented Aug 23, 2023

Uh oh!

alexcrichton commented Aug 24, 2023

Uh oh!

Mossaka commented Sep 3, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Mossaka Sep 14, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

cardoso commented Sep 4, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ydnar Sep 14, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Mossaka commented Aug 23, 2023 •

edited

Loading

Mossaka commented Sep 3, 2023 •

edited

Loading

Mossaka Sep 14, 2023 •

edited

Loading

cardoso commented Sep 4, 2023 •

edited

Loading

ydnar Sep 14, 2023 •

edited

Loading

ydnar commented Sep 14, 2023 •

edited

Loading