Skip to content

Break blocks from near to far, place blocks from far to near. Support… #4706

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: 1.19.4
Choose a base branch
from

Conversation

0xhtml
Copy link

@0xhtml 0xhtml commented Apr 13, 2025

… replaceable blocks. e.g. don't mine single layer snow before placing

… replaceable blocks. e.g. don't mine single layer snow before placing
@ZacSharp
Copy link
Collaborator

This completely breaks breaking replaceable blocks.

0001-0200.mp4

Besides that, it would be nice if you split your changes into multiple commits. Changing the iteration order is mostly white space changes (plus the new fields), but since you combined it with moving lots of checks around it is hard to see what you did.

Also, since you combined int triples into BetterBlockPos wherever you came by one, I'd like to let you know that using ints in places which are executed a lot is done intentionally to avoid allocating and throwing away a thousand BetterBlockPos objects per tick. Obviously, allocating the same position multiple times is right against that goal.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants