Add PrimaryKeySessionAuthenticator #710
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markstory
reviewed
Apr 20, 2025
| ->expects($this->exactly(2)) | ||
| ->method('check') | ||
| ->with( | ||
| ...static::withConsecutive(['Auth'], ['Auth']), |
There was a problem hiding this comment.
This is copy and paste from the other Session test.
| public function __construct(IdentifierInterface $identifier, array $config = []) | ||
| { | ||
| $config += [ | ||
| 'identifierKey' => 'key', |
There was a problem hiding this comment.
If you're inheriting from SessionAuthenticator how does identifierKey interact with fields?
What is key here? I don't see that as a field in the auth_users table that your tests use. Is it primarily to be aligned with the identifier configuration?
There was a problem hiding this comment.
key here maps to the dataField of the identifier, this is how they pass in the data.
There was a problem hiding this comment.
fields is unused afaik.
dereuromark
force-pushed
the
3.x-session-auth
branch
from
a7a1c8c to
3825a48
Compare
dereuromark
force-pushed
the
3.x-session-auth
branch
from
3825a48 to
fba18a2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces #707
Ports dereuromark/cakephp-tinyauth#153 as direct class into this plugin.