Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: sticky-shell in event-types #20566

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

feat: sticky-shell in event-types #20566

wants to merge 5 commits into from
+2 −2

Conversation

TusharBhatt1
Copy link
Contributor

What does this PR do?

Makes the shell sticky for better UX

Visual Demo (For contributors especially)

A visual demonstration is strongly recommended, for both the original and new change (video / image - any one).

Video Demo (if applicable):

  • Show screen recordings of the issue or feature.
  • Demonstrate how to reproduce the issue, the behavior before and after the change.

Image Demo (if applicable):

  • Add side-by-side screenshots of the original and updated change.
  • Highlight any significant change(s).

Mandatory Tasks (DO NOT REMOVE)

  • I have self-reviewed the code (A decent size PR without self-review might be rejected).
  • I have updated the developer docs in /docs if this PR makes changes that would require a documentation change. If N/A, write N/A here and check the checkbox.
  • I confirm automated tests are in place that prove my fix is effective or that my feature works.

How should this be tested?

  • Are there environment variables that should be set?
  • What are the minimal test data to have?
  • What is expected (happy path) to have (input and output)?
  • Any other important info that could help to test that PR

Checklist

  • I haven't read the contributing guide
  • My code doesn't follow the style guidelines of this project
  • I haven't commented my code, particularly in hard-to-understand areas
  • I haven't checked if my changes generate no new warnings

@graphite-app graphite-app bot added the community Created by Linear-GitHub Sync label Apr 6, 2025
@graphite-app graphite-app bot requested a review from a team April 6, 2025 04:47
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Apr 6, 2025

Hey there and thank you for opening this pull request! 👋🏼

We require pull request titles to follow the Conventional Commits specification and it looks like your proposed title needs to be adjusted.

Details:

No release type found in pull request title "feat:sticky-shell". Add a prefix to indicate what kind of release this pull request corresponds to. For reference, see https://www.conventionalcommits.org/

Available types:
 - feat: A new feature
 - fix: A bug fix
 - docs: Documentation only changes
 - style: Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc)
 - refactor: A code change that neither fixes a bug nor adds a feature
 - perf: A code change that improves performance
 - test: Adding missing tests or correcting existing tests
 - build: Changes that affect the build system or external dependencies (example scopes: gulp, broccoli, npm)
 - ci: Changes to our CI configuration files and scripts (example scopes: Travis, Circle, BrowserStack, SauceLabs)
 - chore: Other changes that don't modify src or test files
 - revert: Reverts a previous commit

TusharBhatt1
TusharBhatt1 commented Apr 6, 2025
View reviewed changes
packages/features/shell/Shell.tsx
@@ -125,14 +125,14 @@ export default function Shell(props: LayoutProps) {

export function ShellMain(props: LayoutProps) {
const router = useRouter();
const { isLocaleReady, t } = useLocale();
const { isLocaleReady } = useLocale();
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No being used here

@keithwillcode keithwillcode added the community-interns The team responsible for reviewing, testing and shipping low/medium community PRs label Apr 6, 2025
@dosubot dosubot bot added the 🧹 Improvements Improvements to existing features. Mostly UX/UI label Apr 6, 2025
@graphite-app Graphite App
Copy link

graphite-app bot commented Apr 6, 2025 •
edited
Loading

Graphite Automations

"Add consumer team as reviewer" took an action on this PR • (04/06/25)

1 reviewer was added to this PR based on Keith Williams's automation.

"Add community label" took an action on this PR • (04/06/25)

1 label was added to this PR based on Keith Williams's automation.

"Add ready-for-e2e label" took an action on this PR • (04/07/25)

1 label was added to this PR based on Keith Williams's automation.

@TusharBhatt1 TusharBhatt1 changed the title feat:sticky-shell feat: sticky-shell Apr 6, 2025
@vercel Vercel
Copy link

vercel bot commented Apr 6, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
cal ⬜️ Ignored (Inspect) Visit Preview Apr 7, 2025 9:32am
calcom-web-canary ⬜️ Ignored (Inspect) Visit Preview Apr 7, 2025 9:32am

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Apr 6, 2025 •
edited
Loading

E2E results are ready!

@PeerRich PeerRich enabled auto-merge (squash) April 7, 2025 09:29
@PeerRich PeerRich changed the title feat: sticky-shell feat: sticky-shell in event-types Apr 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PeerRich PeerRich PeerRich approved these changes

Assignees
No one assigned
Labels
community Created by Linear-GitHub Sync community-interns The team responsible for reviewing, testing and shipping low/medium community PRs 🧹 Improvements Improvements to existing features. Mostly UX/UI ready-for-e2e
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@TusharBhatt1 @PeerRich @keithwillcode