Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add multilingual support for Reminder/Rating templates #20573

Closed
wants to merge 10 commits into from
Closed

feat: Add multilingual support for Reminder/Rating templates #20573

wants to merge 10 commits into from
+637 −123

Conversation

giripatel
Copy link

@giripatel giripatel commented Apr 6, 2025 •
edited
Loading

What does this PR do?

Image Demo :

Before:-
Screenshot from 2025-04-07 01-09-23
After:-
Screenshot from 2025-04-06 01-51-59

Mandatory Tasks (DO NOT REMOVE)

  • I have self-reviewed the code (A decent size PR without self-review might be rejected).
  • I have updated the developer docs in /docs if this PR makes changes that would require a documentation change. If N/A, write N/A here and check the checkbox.
  • I confirm automated tests are in place that prove my fix is effective or that my feature works.

How should this be tested?

  1. Create a workflow by clicking on "Workflows".
  2. Navigate to "My Settings" > "General".
  3. Switch to non-English language (e.g. French)
  4. Navigate back to the created workflow.
  5. Click on "Reminder / Rating" Message Template.
  6. Click save and reopen.
  7. Template remains in selected language
  • Are there environment variables that should be set?

No new environment variables are required for this feature.

  • What are the minimal test data to have?

A workflow with email reminder/rating template.

  • What is expected (happy path) to have (input and output)?

Access to multi-language template.

  • Any other important info that could help to test that PR

No

Sorry, something went wrong.

@vercel Vercel
Copy link

vercel bot commented Apr 6, 2025

@giripatel is attempting to deploy a commit to the cal Team on Vercel.

A member of the Team first needs to authorize it.

@CLAassistant
Copy link

CLAassistant commented Apr 6, 2025 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@graphite-app graphite-app bot requested review from a team April 6, 2025 20:10
@graphite-app graphite-app bot added the community Created by Linear-GitHub Sync label Apr 6, 2025
@github-actions github-actions bot added consumer High priority Created by Linear-GitHub Sync i18n area: i18n, translations workflows area: workflows, automations labels Apr 6, 2025
@graphite-app Graphite App
Copy link

graphite-app bot commented Apr 6, 2025 •
edited
Loading

Graphite Automations

"Add consumer team as reviewer" took an action on this PR • (04/06/25)

1 reviewer was added to this PR based on Keith Williams's automation.

"Add foundation team as reviewer" took an action on this PR • (04/06/25)

1 reviewer was added to this PR based on Keith Williams's automation.

"Add community label" took an action on this PR • (04/06/25)

1 label was added to this PR based on Keith Williams's automation.

"Add ready-for-e2e label" took an action on this PR • (04/08/25)

1 label was added to this PR based on Keith Williams's automation.

@retrogtx
Copy link
Contributor

retrogtx commented Apr 7, 2025

The workflow translations work well!

However for some languages, the key is not being updated to the users language, like Event:, Date & Time: etc.

Can this be fixed @giripatel ?

image

retrogtx
retrogtx reviewed Apr 7, 2025
View reviewed changes
packages/features/ee/workflows/lib/test/compareReminderBodyToTemplate.test.ts
@@ -21,12 +22,13 @@ describe("compareReminderBodyToTemplate", () => {
});

describe("email templates", () => {
test("reminder", () => {
test("reminder", async () => {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also this test might be failing, you might wanna check this

retrogtx
retrogtx previously approved these changes Apr 8, 2025
View reviewed changes
@giripatel
Copy link
Author

The workflow translations work well!

However for some languages, the key is not being updated to the users language, like Event:, Date & Time: etc.

Can this be fixed @giripatel ?

image

Hey @retrogtx , I’ve manually checked all the languages in the Languages section but couldn't find any issue with the keys. Could you please let me know which language you're facing the issue in?

@retrogtx
Copy link
Contributor

retrogtx commented Apr 8, 2025

it's nearly all of them, but oddly it's fine in your image

the key "event" still appears to be english even in your after image too

@retrogtx
Copy link
Contributor

retrogtx commented Apr 9, 2025

This is what I am talking about ->

Screen.Recording.2025-04-09.at.9.22.37.AM.mov

@retrogtx
Copy link
Contributor

retrogtx commented Apr 9, 2025

For reference:

image

@retrogtx
Copy link
Contributor

retrogtx commented Apr 9, 2025

hey @giripatel the functionality is great, we can get the failing tests now 🙏

retrogtx
retrogtx previously approved these changes Apr 9, 2025
View reviewed changes
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Apr 11, 2025 •
edited
Loading

E2E results are ready!

retrogtx
retrogtx reviewed Apr 11, 2025
View reviewed changes
Copy link
Contributor

@retrogtx retrogtx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we not revert the yarn.lock and package.json changes?

@giripatel giripatel mentioned this pull request Apr 12, 2025
Open
3 tasks
@retrogtx
Copy link
Contributor

Closing since we are continuing with this PR: #20674

@retrogtx retrogtx closed this Apr 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@retrogtx retrogtx

Assignees
No one assigned
Labels
community Created by Linear-GitHub Sync consumer High priority Created by Linear-GitHub Sync i18n area: i18n, translations ready-for-e2e workflows area: workflows, automations
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[CAL-5392] Translate workflow templates
3 participants
@giripatel @CLAassistant @retrogtx