fix: improved 'use-identity-login' error message for users trying to signInn using different provider #20582
Conversation
…n using different provider
|
@Romitgabanii is attempting to deploy a commit to the cal Team on Vercel. A member of the Team first needs to authorize it. |
github-actions
bot
added
authentication
Graphite Automations"Add consumer team as reviewer" took an action on this PR • (04/07/25)1 reviewer was added to this PR based on Keith Williams's automation. "Add community label" took an action on this PR • (04/07/25)1 label was added to this PR based on Keith Williams's automation. "Add ready-for-e2e label" took an action on this PR • (04/08/25)1 label was added to this PR based on Keith Williams's automation. |
|
|
E2E results are ready! |
|
Hey @anikdhabal @retrogtx Sorry to say but i missed to commit one file in this PR, and currently it's in process of merging. 
|
|
@romitg2 You add/commit/push that file, we will re-review and approve |
| @@ -950,7 +950,7 @@ export const getOptions = ({ | |||
| return true; | |||
| } | |||
| } else if (existingUserWithEmail.identityProvider === IdentityProvider.CAL) { | |||
| return "/auth/error?error=use-password-login"; | |||
| return `/auth/error?error=use-identity-login&provider=${existingUserWithEmail.identityProvider}`; | |||
There was a problem hiding this comment.
I think the error code use-identity-login doesn't make sense in this case as it is email and password case and not identity provider.
How about we change the error to something generic like, "wrong-provider" and then we can handle all cases under this error instead of use-identity-login
| : provider === IdentityProvider.CAL | ||
| ? "Email and Password" | ||
| : provider === IdentityProvider.SAML | ||
| ? "SAML" |
There was a problem hiding this comment.
| ? "SAML" | |
| ? "SAML(like Okta)" |
There was a problem hiding this comment.
Great work so far @romitg2 !! Left some comments to be addressed
Thanks. Fixed and Tested. 
|
…t provider
What does this PR do?
improves 'use-identity-login' error message for users trying to signin using different provider.
Before Change: (was like)
After Change:
how I solved?
changes made:
How should this be tested?
Mandatory Tasks (DO NOT REMOVE)
redirects to this page: (i added query parameter which passes original provider information to error page)