Skip to content

Add ImageMagick support #81

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

yoursdearboy
Copy link

This PR adds ImageMagick support and fixes #1.

Build script installs ImageMagick 6 dependency via brew and links it manually (because imagemagick@6 is a keg-only formula and we don't need another imagemagick formula anyway).

Then copies shared libraries as usual and coders directory manually to the bundle.

To make lookup work I added three new environment variables to startup script (see this SO question). But I'm not sure whether it's a good idea to set DYLD_LIBRARY_PATH.

Tested with Mac OS 10.14.6.

@dsedivec
Copy link

Just a note that Emacs HEAD, "no longer defaults to using ImageMagick to display images,
due to security and stability concerns"
, and will no longer build with ImageMagick support by default AFAIK.

@yoursdearboy
Copy link
Author

Does it mean that by default (without the flag) we won’t be able to manipulate images (resize, rotate, etc)? I use it to display images miniatures. I think this is an important feature for org-mode users to enable by default.

@dsedivec
Copy link

Does it mean that by default (without the flag) we won’t be able to manipulate images (resize, rotate, etc)? I use it to display images miniatures. I think this is an important feature for org-mode users to enable by default.

Sound like no, you won't need ImageMagick, at least not to resize and rotate. I found this in master's etc/NEWS:

Emacs now supports resizing and rotating images without ImageMagick. All modern systems support this feature. (On GNU and Unix systems, Cairo drawing or the XRender extension to X11 is required for this to be available; the configure script will test for it and, if found, enable scaling.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ImageMagick Support
2 participants