Skip to content

chore: add single nat option for EKS #266

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Apr 16, 2025
Merged

chore: add single nat option for EKS #266

merged 4 commits into from
Apr 16, 2025

Conversation

Langleu
Copy link
Member

@Langleu Langleu commented Apr 15, 2025 •
edited
Loading

related to https://github.com/camunda/team-infrastructure-experience/issues/539

  • Adds single nat gateway option for EKS (false by default), so preserving the old behaviour
  • For the tests we're overwriting it and just using a single nat to save on IPs
  • adjusted the IP check to properly reflect usage

image

Skipped module tests for the rerun as they passed and didn't change based on the fix for the eks single-region stuff.

Langleu added 2 commits April 14, 2025 14:12
@Langleu
chore: introduce option single nat gateway for eks
60ff2e1
@Langleu
chore: adjusts tests to make default
f86b35e 
chore: adjust eip check to consider single nat or nat per az
@Langleu Langleu self-assigned this Apr 15, 2025
@Langleu Langleu requested a review from bkenez April 15, 2025 11:28
@github-actions github-actions bot added the test label Apr 16, 2025
bkenez
bkenez approved these changes Apr 16, 2025
View reviewed changes
Copy link
Member

@bkenez bkenez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@Langleu Langleu merged commit 2c6dfb3 into main Apr 16, 2025
25 checks passed
@Langleu Langleu deleted the infraex-539 branch April 16, 2025 10:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leiicamundi leiicamundi leiicamundi left review comments

@bkenez bkenez bkenez approved these changes

Assignees

@Langleu Langleu

Labels
skip_aws_compute_ec2_single_region_tests skip_aws_kubernetes_eks_single_region_tests skip_aws_modules_eks_rds_os_create_destruct_tests skip_aws_openshift_rosa_hcp_dual_region_tests skip_aws_openshift_rosa_hcp_single_region_tests test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Langleu @bkenez @leiicamundi