Skip to content

Use modern Go constructs #215

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

HadrienPatte
Copy link
Contributor

  • Have you signed the CLA?

Use modern Go constructs:

  • replace interface{} with any (available since go1.18)
  • replace 3-clause loop with range loop (available since go1.22)
  • use slices package (available since go1.21)

Copy link

github-actions bot commented Apr 9, 2025

Command Mean [s] Min [s] Max [s] Relative
BASE 9.085 ± 0.021 9.056 9.110 1.01 ± 0.01
HEAD 9.038 ± 0.059 8.936 9.118 1.00

@letFunny
Copy link
Collaborator

@HadrienPatte Thanks for this and apologies for not reviewing it. At the moment we are focused on delivering some major features that will significantly improve the UX. Once we are done with those we will prioritize reviewing and merging this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants