Added section about async profiler with cf java #1771
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Spelling Mistakes
- java/operating-applications/optimizing.md:56:8 Unknown word "Asprof"
- java/operating-applications/optimizing.md:57:34 Unknown word "asprof"
Generally, for each spelling mistake there are 2 ways to fix it:
- Fix the spelling mistake and commit it.
- The word is incorrectly reported as misspelled → put the word on the project-words.txt list, located in the root project directory.
| Choosing an output filename with .html ending indicates to use the output type `flamegraph`, see [FlameGraph visualization](https://github.com/async-profiler/async-profiler/blob/master/docs/GettingStarted.md#flamegraph-visualization) | ||
| ::: | ||
|
|
||
| `.html` files can be opened in a browser, `.jfr` files can be viewed with a viewer such as [OpenJDK Mission Control](https://openjdk.org/projects/jmc/). |
There was a problem hiding this comment.
can jfr files also be opened in intellij or vscode?
There was a problem hiding this comment.
In IntelliJ only with the Ultimate Edition. For VSCode I'm not aware of any extension that could open jfr files.
There was a problem hiding this comment.
Johannes hat ein PLugin für intellij gebaut - nur das ist eher noch instabil. Du kannst ihn ja fragen, ob wir es schon verlinken sollen
There was a problem hiding this comment.
Linting Errors
- java/operating-applications/optimizing.md:73 Fenced code blocks should have a language specified
- java/operating-applications/optimizing.md:78 Fenced code blocks should have a language specified
- java/operating-applications/optimizing.md:83 Fenced code blocks should have a language specified
- java/operating-applications/optimizing.md:88 Fenced code blocks should have a language specified
- java/operating-applications/optimizing.md:93 Fenced code blocks should have a language specified
- java/operating-applications/optimizing.md:98 Fenced code blocks should have a language specified
- java/operating-applications/optimizing.md:103 Fenced code blocks should have a language specified
|
@renejeglinsky, @smahati, we still need a review from one of you. We'd like to have this merged before the upcoming CAP Java release. |
|
|
||
| #### Async Profiler | ||
|
|
||
| Using `cf java` to profile Java applications running on Cloud Foundry with the [Async Profiler](https://github.com/async-profiler/async-profiler?tab=readme-ov-file#async-profiler) requires **recent versions** of the **SAP Java Buildpack with SAPMachine 17** (`1.110.0`) and **21** (`2.24.0`). |
There was a problem hiding this comment.
How do I ensure this? Does our tooling (cds add mta) define a buildpack that fulfills this requirement?
There was a problem hiding this comment.
Yes cds add mta fulfills this. It does not declare a specific version for the buildpack, and then the latest release is used which includes the aysnc-profiler. So unless you manually change the versioning, you'll meet the requirement.
There was a problem hiding this comment.
I think that should be mentioned in the async-profiler readme as well (and then we could just mention and link ;) )
Shall we make a contribution for that?
There was a problem hiding this comment.
We could, but I honestly think their readme is worse and has too much clutter for our target audience.
| ```txt | ||
| Start an async-profiler CPU-time profile recording on a running Java application | ||
| ``` |
There was a problem hiding this comment.
This an unusual pattern. Why did you decide for this?
There was a problem hiding this comment.
Personal choice, as it's similar to what I get as output when I use the help of the cf java CLI. But we can change this, if there's a better pattern.
There was a problem hiding this comment.
I understand. As we're not positioning this as help text from the CLI (then we would need to make sure that it's always up to date) we can use just normal text. Agreed? I'll do the change then.
Added section about how to use the https://github.com/SAP/cf-cli-java-plugin to run profiling with asprof.