[WIP] Doc improvements on 'Custom Builds' #1837
Draft
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes in This PR
monospace font
(rather than italics, which is used more for file names)Open Problems/ Questions
I added a related snippet for convenient searching of the relevant section, followed by my feedback.
🔴 the following example doesn't really make it clear how the behaviour can be changed or what the options shown in the configuration do exactly.
🔴 How else should we do it then?
The link then leads to an external blog entry about monorepos.
🟡 This feels a bit weird and out of place. There doesn't seem to be an official guide about mono repos, which is probably the reason why this link was used instead. But maybe we can find something else?
The section then lists various parameters for the
for
parameter.🟡 I am not entirely sure how to feel about this section. While it currently seems to be up to date, it will inherently become outdated at some point and is basically a clone of what
cds build --help
would list under the appropriate section for--for
. Could we instead have the output ofcds build --help
here and make that more explicit instead? We do this similarly for cds-typer.🟡 The following section shows an example of a configuration done in package.json. This is one of multiple places where we can see this pattern. We have the
<Config>
custom tag to show various ways of including a configuration, aside from package.json nowadays. Could/ should we use this more excessively here?🔴 This needs an example!
The following code blocks shows an outdated version of the postgres build plugin.
🔴 I don't think we should duplicate the code at this point. We link to the
main
branch of the repository containing this plugin just above. I don't see how showing a larger code block that will inherently be outdated without added explanation brings any value to the table. (The section after that does go into detail about some of the methods, but not all. So even if we wanted to use this particular plugin as an illustration of the API, it is just not complete and would benefit more from having the actual API doc included at this point.)Opportunity to include exported type information inside CAPire?! @chgeo