Add flag for the SoftFail case of the LLVM disassembler. #2707
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Your checklist for this pull request
Detailed description
The LLVM disassembler returns SoftFail if the instruction can be decoded, but it is illegal due to other reasons.
E.g. because it uses operands it is not allowed to use or the instructions is invalid in a given context.
New
cstool
output:Test plan
Added.
I didn't went through the trouble looking up a SoftFail case for each architecture.
But added the instructions from the issues and null-hypothesis test cases.
Can't reproduce the instruction sequence from #1991. No idea what I did there. But it is not added as use case.
Closing issues
closes #2703
closes #1991