Skip to content

Fix missing sp register read in ret instruction #2719

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: next
Choose a base branch
from
Open

Fix missing sp register read in ret instruction #2719

wants to merge 1 commit into from

Conversation

jiegec
Copy link
Contributor

@jiegec jiegec commented May 24, 2025 •
edited
Loading

Your checklist for this pull request

  • I've documented or updated the documentation of every API function and struct this PR changes.
  • I've added tests that prove my fix is effective or that my feature works (if possible)

Detailed description

Fix missing sp register read in x86 ret instruction.

Test plan

./suite/cstest/cstest ../tests/details/x86.yaml

Closing issues

closes #2714.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Rot127 Rot127 Rot127 approved these changes

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
LLVM-generated-files X86 Arch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Ret on x86 does not include sp in registers read
2 participants
@jiegec @Rot127