Skip to content

Add helper functions for measuring and comparing distributions #1713

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 5 commits into
base: develop
Choose a base branch
from

Conversation

sethrj
Copy link
Member

@sethrj sethrj commented Apr 3, 2025

This is to be used for understanding physics distributions (e.g. exiting polar angle) and for robustness against future refactors. Caveats:

  • The classes were generated with the help of Copilot.
  • I think the distribution comparison tests are wrong; the goal is to estimate the mean and variance of the underlying distribution, and to estimate how good that estimate is (variance of the variance?), and to be able to make comparisons based on those.
  • This class itself could use tests.
  • It may also belong in the main codebase rather than inside /test.
  • We should consider using/requiring boost or another lighter library with statistics support to do the actual confidence tests.

@sethrj sethrj requested a review from amandalund April 3, 2025 01:07
Copy link

github-actions bot commented Apr 3, 2025

Test summary

 4 050 files   6 202 suites   4m 23s ⏱️
 1 433 tests  1 425 ✅  8 💤 0 ❌
19 901 runs  19 827 ✅ 74 💤 0 ❌

Results for commit 7c0ed51.

♻️ This comment has been updated with latest results.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant