Skip to content

Adjust mappings+settings to ignore periods in company names #65

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

higs4281
Copy link
Member

@higs4281 higs4281 commented Sep 6, 2022

The suggester for the 'Company name' filter gets led astray when company names have periods in them, such as 'U.S. Bancorp' If a user types in 'US Banc', nothing is suggested.

This change adds a filter and analyzer for Company name suggestions that ignores periods, so that either 'US Banc' or 'U.S. Banc' will suggest U.S. BANCORP.

This satisfies internal issue 2209. It works in Complaint Explorer, and will be tested in CCDB on a DEV server with reindexed data.

The suggester for the 'Company name' filter gets led astray when
company names have periods in them, such as 'U.S. Bancorp'
If a user types in 'US Banc', nothing is suggested.

This change adds a filter and analyzer for Company name suggestions
that ignores periods, so that either 'US Banc' or 'U.S. Banc' will suggest
U.S. BANCORP.

This satisfies internal issue 2209.
@higs4281 higs4281 changed the title Adjust mappings settings to ignore periods in company names Adjust mappings+settings to ignore periods in company names Sep 7, 2022
@higs4281 higs4281 marked this pull request as draft September 7, 2022 18:24
@higs4281
Copy link
Member Author

higs4281 commented Sep 7, 2022

Putting this on hold to chase an error that showed up when tested in DEV5.
FYI, the DEV5 test of this code has been reverted. so periods are still honored for company name suggestions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant