fix: Always create cc_library targets if C/C++ files are present #1594
+225
−52
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jflan-dd
requested review from
brentleyjones,
cgrindel,
jpsim and
luispadron
as code owners
|
This PR helps in supporting KSCrash as well, see this issue |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I ran into an issue were we couldn't build the InjectionNext package because there was a C file that wasn't being included in the
srcslist of any generated target.This was because most of the code is in Objective-C++, which creates a target that doesn't include C source files.
This change always creates a dedicated
cc_librarytarget for any C/C++ code in the package.