Skip to content

🚸 feat: Change default checksumMode from local to remote #1199

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

LogFlames
Copy link
Member

See #1192.

This change should be merged together with #1193 to ensure our default is always to use strong checksums. Also note that when regenerating old lockfiles the config will be loaded from those files as discussed in #1188. A manual update would have to be created using:

mvn io.github.chains-project:maven-lockfile:generate -DgetConfigFromLockfile=false [... additional parameters such as includeMavenPlugins etc.]

@LogFlames LogFlames linked an issue May 5, 2025 that may be closed by this pull request
@LogFlames LogFlames changed the title 🚸 feat: Change default parameter from local to remote 🚸 feat: Change default checksumMode from local to remote May 5, 2025
@monperrus
Copy link
Contributor

Promising PR, thanks @LogFlames

This change should be merged together with #1193 to ensure our default is always to use strong checksums.

Merged together? Can we rather serialize?

@LogFlames
Copy link
Member Author

LogFlames commented May 6, 2025

Merged together? Can we rather serialize?

Yes thats a better idea, but we should fix #1193 first.

@LogFlames LogFlames marked this pull request as ready for review May 7, 2025 11:49
LogFlames and others added 3 commits May 7, 2025 15:24
Enable sha256 and sha512 for maven central
In case sha256/sha512 is missing from remote, download file, verify with
sha1, and calculate new checksum
@LogFlames LogFlames force-pushed the 1192-checksums-change-default-to-remote branch from 12243a0 to 63d8377 Compare May 7, 2025 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

checksums: change default to "remote"
2 participants