Skip to content

Create automated CLA checking #6575

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Create automated CLA checking #6575

wants to merge 1 commit into from

Conversation

Fly-Style
Copy link
Contributor

This PR introduces automated CLA checking using CLA Assistant service.
I create CLA there, and connect newly-created agreement to CC's repository.
I used this service on my previous projects and it worked fine 2 years ago. I'll gonna check it now.

@CLAassistant
Copy link

CLAassistant commented Jan 11, 2021

CLA assistant check
All committers have signed the CLA.

@Fly-Style Fly-Style requested review from ppenzin and rhuanjl January 11, 2021 12:19
@Fly-Style Fly-Style added this to the vCommunity (1.12) milestone Jan 11, 2021
@Fly-Style Fly-Style self-assigned this Jan 11, 2021
@Fly-Style
Copy link
Contributor Author

Fly-Style commented Jan 11, 2021

As you can see, it works fine.
I can launch a refresh process for all PR's to check signed CLA.

@Fly-Style Fly-Style marked this pull request as ready for review January 11, 2021 12:21
@rhuanjl
Copy link
Collaborator

rhuanjl commented Jan 11, 2021

Couple of questions:

  1. How does this work - is it checking against the agreement we have in the repository to see who has signed it or is it linking to a copy somewhere else?
  2. How/where can we review the setup for this - this PR just adds a badge to the readme right?

Other thoughts:

  1. Before we merge I'd like to see what it says to a PR from someone who hasn't signed
  2. I'm 50/50 if we should re-launch it on old PRs, anything submitted before the migration to our control in December was submitted under the Microsoft CLA and can be considered copyright microsoft and already appropriately licensed - we only need this for stuff submitted after the migration (i.e. future PRs + Fixed issue when syntax error is not thrown when an expression within if is comma-terminated #6551 and Add style checks #6571 )

@Fly-Style
Copy link
Contributor Author

  1. How does this work - is it checking against the agreement we have in the repository to see who has signed it or is it linking to a copy somewhere else?

Yes, it is not agreement that we have in repository : unfortunately, it works only with gist.
This service copies CLA text from there and wraps by CLA management system.

  1. How/where can we review the setup for this - this PR just adds a badge to the readme right?

Yes, if someone want to sign it without creating a PR.
All work was done in a background on https://cla-assistant.io .

@ppenzin
Copy link
Member

ppenzin commented Jan 12, 2021

The list is in the app?

Having status of CLA signing not depend on the state of the repo has its benefits - that means that PR would not have to be rebased when the author signs the agreement.

@Fly-Style
Copy link
Contributor Author

@rhuanjl @ppenzin any thoughts?

@rhuanjl
Copy link
Collaborator

rhuanjl commented Jan 26, 2021

@Fly-Style we've been comparing with an alternative - see #6578

@rhuanjl
Copy link
Collaborator

rhuanjl commented Jan 29, 2021

Superseded by #6578

@rhuanjl rhuanjl closed this Jan 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants