Remove JS escaping from amp_post_template_analytics
filter callback
#22
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes some extraneous calls to
esc_js
in theamp_post_template_analytics
filter callback as the nestedconfig_data
array is already JSON encoded, when printed out to the page, in the AMP plugin:Also the
esc_js
calls don't seem to be as useful since the output goes to the contents of aapplication/json
script
element (i.e., not inline JavaScript):https://developer.wordpress.org/reference/functions/esc_js/
Thanks!