fix: do not attempt to reference info messages #6023
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Due to another bug #5994 info messages were not actually used in In-Reply-To and message simply had no The test in this PR is failing without the fix, just in unexpected way. |
Hocuri
approved these changes
Oct 3, 2024
Hocuri
reviewed
Oct 3, 2024
src/chat.rs
Outdated
| @@ -1236,6 +1237,9 @@ impl ChatId { | |||
| // Do not reply to not fully downloaded messages. Such a message could be a group chat | |||
| // message that we assigned to 1:1 chat. | |||
| DownloadState::Done as u32, | |||
| // Do not reference info messages, they are not actually sent outside | |||
There was a problem hiding this comment.
Grammar: Probably should be "sent out" instead of "sent outside"?
Info messages are added
at the beginning of unpromoted group chats
("Others will only see this group after you sent a first message."),
may be created by WebXDC etc.
They are not sent outside
and have local Message-ID that
is not known to other recipients
so they should be skipped when constructing
In-Reply-To and References.
link2xt
force-pushed
the
link2xt/dont-reference-info
branch
from
f81b531 to
637a3f6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Info messages are added
at the beginning of unpromoted group chats
("Others will only see this group after you sent a first message."), may be created by WebXDC etc.
They are not sent outside
and have local Message-ID that
is not known to other recipients
so they should be skipped when constructing
In-Reply-To and References.