[WIP] feat: In debug builds, panic on errors in C bindings #6844
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Legacy Python tests for incorrect calls should probably be removed. |
Hocuri
changed the title
|
Looks reasonable, but should probably be |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to get a chance on finding the root cause of errors such as deltachat/deltachat-android#3756, I suggest that we panic on errors with debug assertions enabled. This way, we get the the root error message and can fix the problem.
This is in line with us adding
debug_assert!()in some places, and it will only apply for people like myself who are building their own APK withscripts/ndk-make.sh --debug. Every other APK, including the preview APKs build here on GitHub for every PR, are not affected.I didn't test this yet, first wanted to ask whether you think something like this might be reasonable.