Add tabs to the lighting table, add separate per-platform tables #370
+77
−19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…platform column from the table(s), add a Notes column for A300 to note that the flashing corner of the Motor Fault state is important
civerachb-cpr
requested review from
rhysfaultless-cpr,
jhiggins-cpr,
tonybaltovski and
hilary-luo
as code owners
| @@ -6,6 +6,9 @@ toc_min_heading_level: 2 | |||
| toc_max_heading_level: 5 | |||
| --- | |||
|
|
|||
| import Tabs from '@theme/Tabs'; | |||
| import TabItem from '@theme/TabItem'; | |||
|
|
|||
| Corner lighting is unified for platforms that support it (D100, D150, R100, W200). Lighting is controlled by the [lighting node](https://github.com/clearpathrobotics/clearpath_robot/tree/jazzy/clearpath_hardware_interfaces/src/lighting) which defines multiple lighting states. | |||
There was a problem hiding this comment.
Can you add A300 to the supported platforms?
|
I wonder if we should remove the priority column altogether with this change? It looks kind of weird when it skips priorities for some robots |
I feel like the priority is still useful, since it indicates what states override others. I agree it's a little weird if numbers get skipped, but the priority values are shared across platforms, so it's accurate. Just a little weird. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace the single lighting table with tabs per-platform. Remove the platform column from the table(s), add a Notes column for A300 to note that the flashing corner of the Motor Fault state is important