Add PR Preview actions #381
Conversation
|
This pull request is automatically being deployed by Amplify Hosting (learn more). |
|
Preview branch generated at https://mh-wip-preview-test.dfy90wyu8dics.amplifyapp.com |
mikehosmar
force-pushed
the
mh/wip/preview-test
branch
from
fa5f073 to
920d085
Compare
|
After @tonybaltovski's comment I adjusted the action to allow the creation of rc branches in Amplify with the built-in preview setting enabled. So this is the best of both worlds. |
mikehosmar
requested review from
rhysfaultless-cpr,
jhiggins-cpr,
tonybaltovski and
hilary-luo
as code owners
| role-to-assume: ${{ secrets.AWS_GITHUB_ACTIONS_ROLE }} | ||
| output-credentials: true | ||
| - name: cleanup PR preview branch | ||
| uses: mikehosmar/amplify-preview-actions@sed-replace-all |
There was a problem hiding this comment.
Can you elaborate on what this dependency is?
There was a problem hiding this comment.
This is an action which contains the amplify commands to create and close branches.
There was a problem hiding this comment.
I just meant to highlight the "uses: mikehosmar/amplify-preview-actions@sed-replace-all" line. I wasn't sure if that was a link to something in your personal account somewhere and, if so, should we move it to a more accessible location.
There was a problem hiding this comment.
I did Fork the action to my account to make sure we have a copy which we control. We could fork it to clearpathrobotics if you would like.
There was a problem hiding this comment.
Yes, it would be preferable to fork to clearpathrobotics.
Switch to standard app for previews
Two options.