-
Notifications
You must be signed in to change notification settings - Fork 354
fix(clerk-js): Do not allow setActive({ organization: null })
when organization selection is forced
#6073
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
🦋 Changeset detectedLatest commit: 5dd6089 The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
aa47320
to
b24bfad
Compare
b24bfad
to
4a473d9
Compare
@clerk/agent-toolkit
@clerk/astro
@clerk/backend
@clerk/chrome-extension
@clerk/clerk-js
@clerk/dev-cli
@clerk/elements
@clerk/clerk-expo
@clerk/expo-passkeys
@clerk/express
@clerk/fastify
@clerk/localizations
@clerk/nextjs
@clerk/nuxt
@clerk/clerk-react
@clerk/react-router
@clerk/remix
@clerk/shared
@clerk/tanstack-react-start
@clerk/testing
@clerk/themes
@clerk/types
@clerk/upgrade
@clerk/vue
commit: |
4a473d9
to
c6cf838
Compare
Some integration tests started to fail after introducing this guard, so I'll deeper tomorrow while also adding error handling on FAPI side. |
c6cf838
to
5dd6089
Compare
Description
Resolves ORGS-682
Disclaimer: We're also going to apply protections on the API side, this is just an additional guard.
Introduces an error guard not to allow calling
setActive({ organization: null })
when organization selection is forced on the instance settings.The same handling should be made when we refactor
setActive
tosetCurrent
👀Checklist
pnpm test
runs as expected.pnpm build
runs as expected.Type of change