documents uploads will use HDFSfileUploadHandler when task_server is on #4044
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Backend Code Coverage Report •
Pytest Report
|
||||||||||||||||||||||||||||||
athithyaaselvam
force-pushed
the
as_dev_documents
branch
from
4794086 to
d828228
Compare
|
|
Harshg999
reviewed
Mar 12, 2025
|
|
||
| def __init__(self, request, *args, **kwargs): | ||
| super().__init__(request, *args, **kwargs) | ||
| if request.path.startswith("/desktop/api2/doc/import"): |
There was a problem hiding this comment.
Try using reverse() instead of hardcoding here?
Comment on lines
+236
to
+238
| self.delegate = HDFSfileUploadHandler(request) | ||
| else: | ||
| self.delegate = FineUploaderChunkedUploadHandler(request, *args, **kwargs) |
There was a problem hiding this comment.
Nit: Better variable naming? Something related to upload handler?
wing2fly
approved these changes
Mar 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Import documents in documents tab are failing, when task server is enabled with error
" File "/opt/hive/desktop/core/src/desktop/api2.py", line 1027, in import_documents
raise PopupException(_('Failed to import documents, the file does not contain valid JSON.'))".
This was because the document upload handler was using
FineUploaderChunkedUploadHandlerwhen theis_chunked_fileuploader_enabledflag is on. No supporting logic was added toFineUploaderChunkedUploadHandlerto support document uploads as the main motive ofFineUploaderChunkedUploadHandlerwas to support large file uploads.So adding a custom upload handler that will delegate the document upload tasks to the
HDFSfileUploadHandlerand rest of the file uploads toFineUploaderChunkedUploadHandlerwhenis_chunked_fileuploader_enabledis on.How was this patch tested?
-tested local setup and Kubernetes setup
Please review Hue Contributing Guide before opening a pull request.