Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix] Fix the xls download stuck problem #4066

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

MonsterChenzhuo
Copy link

What changes were proposed in this pull request?

  • (Please fill in changes proposed in this fix)

How was this patch tested?

  • (Please explain how this patch was tested. Ex: unit tests, manual tests)
  • (If this patch involves UI changes, please attach a screen-shot; otherwise, remove this)

Please review Hue Contributing Guide before opening a pull request.

Copy link

⚠️ No unit test files modified. Please ensure that changes are properly tested. ⚠️

Copy link

⚠️ No unit test files modified. Please ensure that changes are properly tested. ⚠️

Copy link

github-actions bot commented Mar 20, 2025

Backend Codecov

Backend Code Coverage Report •
FileStmtsMissCoverMissing
desktop/core/src/desktop/lib
   export_csvxls.py971188%53–58, 129, 131, 146–147, 154
TOTAL533132612451% 

Pytest Report

Tests Skipped Failures Errors Time
1090 107 💤 0 ❌ 0 🔥 5m 46s ⏱️

@bjornalm
Copy link
Collaborator

Hi @MonsterChenzhuo and thanks for contributing. One of the backend developers in the core team will take a look at this.

@Harshg999
Copy link
Collaborator

Hi @MonsterChenzhuo, thanks for raising a PR contribution! What is the issue you're getting with xls download? What is the use-case and is it cherrypy specific?

Also can you please remove the cherrypy changes from this PR and rebase with latest changes? Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants