-
Notifications
You must be signed in to change notification settings - Fork 383
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improvement - Hue Atlas search for classification and tags #4070
base: master
Are you sure you want to change the base?
Conversation
Based on a discussion with Atlas team, came to know that the query_s for searching classification or tags can be slow in Atlas and can lead to timeouts. Have made the needed changes based on Atlas team and this was tested in CU environment.
|
Backend Code Coverage Report •
Pytest Report
|
'attributeValue': query_s, | ||
'operator': 'contains' | ||
'attributeName': '__typeName', | ||
'operator': 'eq', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you are also switch the operator
from contains
to eq
. Won't this have a significant change in the expected behavior?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@amitsrivastava , The information was provided by Atlas team, I had no idea that there was an operator with eq there. Their recommendation was that Hue issuing contains with query_s causes performances issue and times out when there are too many things to look for and using __typename with eq and the attributevalue helps with getting the data out fast and also does not cause Atlas to perform massive query search operation.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we please add this info as a comment in the code?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I assume eq means exact match? IIRC this search also gets triggered from the top search where we'll need a "contains" search for usability.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm trying to say that we might need both, exact match when fetching details for a known sql entity and contains for user initiated search..
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1 for @JohanAhlen's statement and approach
|
Based on a discussion with Atlas team, came to know that the query_s for searching classification or tags can be slow in Atlas and can lead to timeouts. Have made the needed changes based on Atlas team and this was tested in CU environment.