Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvement - Hue Atlas search for classification and tags #4070

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

quadoss
Copy link
Collaborator

@quadoss quadoss commented Mar 20, 2025

Based on a discussion with Atlas team, came to know that the query_s for searching classification or tags can be slow in Atlas and can lead to timeouts. Have made the needed changes based on Atlas team and this was tested in CU environment.

Based on a discussion with Atlas team, came to know that the query_s for searching classification or tags can be slow in Atlas and can lead to timeouts.
Have made the needed changes based on Atlas team and this was tested in CU environment.
Copy link

⚠️ No unit test files modified. Please ensure that changes are properly tested. ⚠️

@quadoss quadoss enabled auto-merge (squash) March 20, 2025 15:23
Copy link

github-actions bot commented Mar 20, 2025

Backend Codecov

Backend Code Coverage Report •
FileStmtsMissCoverMissing
desktop/libs/metadata/src/metadata/catalog
   atlas_client.py30525516%63, 65, 68, 70–73, 75–78, 80–82, 84–85, 87–91, 93, 95–96, 101, 103–111, 113, 116, 138–145, 147–152, 154, 183, 188–190, 193, 196–197, 199–200, 202–205, 207, 211–212, 214, 216, 220–221, 223, 225, 229–230, 233, 235, 239, 248–252, 254–255, 257, 259–261, 264–268, 270–273, 275–278, 280, 309–310, 316–317, 323–324, 327–330, 332–335, 337, 341–342, 344–349, 351–353, 358–360, 362–364, 371, 373–374, 376, 379–381, 383–386, 388, 391–395, 397, 404–409, 416, 418, 424–425, 427, 429–431, 433, 436, 446–449, 452–457, 460, 462–470, 473–478, 485–486, 488, 492–495, 497, 500–505, 507, 510–514, 516, 519–521, 523–525, 527, 530–534, 536, 539–541, 543–545, 547, 550–554, 556, 561–564, 566, 568–569, 581–582, 587, 590, 600, 603
TOTAL533132612451% 

Pytest Report

Tests Skipped Failures Errors Time
1090 107 💤 0 ❌ 0 🔥 5m 50s ⏱️

'attributeValue': query_s,
'operator': 'contains'
'attributeName': '__typeName',
'operator': 'eq',
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you are also switch the operator from contains to eq. Won't this have a significant change in the expected behavior?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@amitsrivastava , The information was provided by Atlas team, I had no idea that there was an operator with eq there. Their recommendation was that Hue issuing contains with query_s causes performances issue and times out when there are too many things to look for and using __typename with eq and the attributevalue helps with getting the data out fast and also does not cause Atlas to perform massive query search operation.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we please add this info as a comment in the code?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume eq means exact match? IIRC this search also gets triggered from the top search where we'll need a "contains" search for usability.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm trying to say that we might need both, exact match when fetching details for a known sql entity and contains for user initiated search..

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 for @JohanAhlen's statement and approach

Copy link

⚠️ No unit test files modified. Please ensure that changes are properly tested. ⚠️

@quadoss quadoss requested a review from amitsrivastava March 20, 2025 23:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants