Skip to content

feat(cluster): extend backup configuration for volumesnapshot and plugin #521

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

m4s-b3n
Copy link

@m4s-b3n m4s-b3n commented Feb 19, 2025

Summary of Changes

New Backup Options

This pull request introduces two new backup options to the chart: volumeSnapshot and plugin. These options provide additional flexibility for configuring backups in the CloudNativePG operator.

Volume Snapshots

  • Added support for volume snapshots as a backup method.
  • Configurable parameters include:
    • className
    • walClassName
    • tablespaceClassName
    • snapshotOwnerReference
    • online
    • onlineConfiguration (with waitForArchive and immediateCheckpoint)

Plugin Backups

  • Added support for plugin-based backups.
  • Configurable parameters include:
    • name
    • parameters

Documentation Updates

  • Updated the README.md and README.md.gotmpl files to include documentation for the new backup options.
  • Provided examples for configuring volume snapshots and plugin backups.

Extended Tests

  • Added new test cases to validate the functionality of the new backup options.
  • Extended the existing test suite to cover scenarios involving volume snapshots and plugin backups.

@m4s-b3n
Copy link
Author

m4s-b3n commented Feb 21, 2025

@itay-grudev please rerun chainsaw tests as the failed one seems to be failed because of an image pull error

@m4s-b3n
Copy link
Author

m4s-b3n commented Feb 24, 2025

@itay-grudev anything else I can do here?

@itay-grudev
Copy link
Collaborator

No. Thanks a lot. I'll review it when I can. I apologize in advance if I delay you, I am just under a lot of pressure right now.

@m4s-b3n
Copy link
Author

m4s-b3n commented Mar 3, 2025

@itay-grudev pull request already got merge conflicts. do you resolve them on merge or do you require me to do this?

@m4s-b3n
Copy link
Author

m4s-b3n commented Mar 12, 2025

@itay-grudev solved the conflicts by rebasing main

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants