fix: respect namespaceOverride for PrometheusRule generation #562
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
size:XS
itay-grudev
approved these changes
Apr 29, 2025
Signed-off-by: Philipp Born <[email protected]>
pborn-ionos
force-pushed
the
fix/cluster/prometheusrule-namespacing
branch
from
7ad63d1 to
ac3a950
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, when the
clusterchart is rendered withnamespaceOverride, the generatedPrometheusRuleobjects use.Release.Namespacefor namespace filtering, which, chances are, does not correlate with the value ofnamespaceOverride.As a result, the generated prometheus rules can't work, since they filter for the wrong namespace.