chore: Port over useTelemetry hook #122
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #122 +/- ##
=======================================
Coverage 99.30% 99.30%
=======================================
Files 29 30 +1
Lines 717 721 +4
Branches 195 188 -7
=======================================
+ Hits 712 716 +4
Misses 5 5 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
just-boris
reviewed
Mar 18, 2025
|
|
||
| export function createUseTelemetry(environment: Environment) { | ||
| return (componentName: string, config?: ComponentConfiguration) => { | ||
| const isVisualRefresh = environment.alwaysVisualRefresh || useRuntimeVisualRefresh(); |
There was a problem hiding this comment.
Suggested change
| const isVisualRefresh = environment.alwaysVisualRefresh || useRuntimeVisualRefresh(); | |
| const isVisualRefresh = environment.alwaysVisualRefresh ?? useRuntimeVisualRefresh(); |
because when alwaysVisualRefresh is false you do not want to fallback to runtime
There was a problem hiding this comment.
In classic this value would be false in the environment file, why wouldn't we want to fallback to runtime?
There was a problem hiding this comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.