-
Notifications
You must be signed in to change notification settings - Fork 98
fix : use default service account for cockroachdb-client-secure #970
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
bhismnarayan
wants to merge
2
commits into
cockroachdb:master
Choose a base branch
from
bhismnarayan:update_service_account
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
fix : use default service account for cockroachdb-client-secure #970
bhismnarayan
wants to merge
2
commits into
cockroachdb:master
from
bhismnarayan:update_service_account
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@cockroach-teamcity @dt @prafull01 can you please review |
prafull01
reviewed
Apr 7, 2025
9cdb2b7
to
bef74a2
Compare
prafull01
reviewed
Apr 15, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please update the PR's heading which reflects its changes.
@prafull01 can you please review? |
prafull01
approved these changes
Apr 24, 2025
@bhismnarayan Can you please rebase your branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
client-secure-operator.yaml has reference to a service account
cockroachdb-sa
which not being created but was referred.Checklist
*In order to fix it I added code block to create
cockroachdb-sa
service account