Skip to content

lexbase: introduce EncAlwaysQuoted fmt flag #15

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

ZhouXing19
Copy link

This PR won't merge with main but create a separate a new tag.

I set it to be merged against main just to enable code review.

To accomodate an oracle query, we need to quote the object name regardless if it is a reserved keyword or is bare identifier. This is because oracle is case insensitive without quotes. This flag is meant to be used ONLY to construct SELECT stmt for oracle source.

For example, in oracle:

CREATE TABLE "t" ("iD" INT PRIMARY KEY, "AcC" INT)

We have to do

SELECT * FROM "t"

Otherwise we will encounter a "table doesn't exist" error.

Release note: None

@ZhouXing19 ZhouXing19 requested a review from Jeremyyang920 June 11, 2024 14:22
To accomodate an oracle query, we need to quote the object name regardless if it is
a reserved keyword or is bare identifier. This is because oracle is case insensitive
without quotes. This flag is meant to be used ONLY to construct SELECT stmt for oracle
source.

For example, in oracle:

```
CREATE TABLE "t" ("iD" INT PRIMARY KEY, "AcC" INT)
```

We have to do

```
SELECT * FROM "t"
```

Otherwise we will encounter a "table doesn't exist" error.

Release note: None
@ZhouXing19 ZhouXing19 force-pushed the encode-always-quoted branch from 4904abb to bb3c0aa Compare June 11, 2024 14:33
@ZhouXing19
Copy link
Author

Thanks! Closing.

@ZhouXing19 ZhouXing19 closed this Jun 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants