lexbase: introduce EncAlwaysQuoted fmt flag #15
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jeremyyang920
approved these changes
Jun 11, 2024
To accomodate an oracle query, we need to quote the object name regardless if it is
a reserved keyword or is bare identifier. This is because oracle is case insensitive
without quotes. This flag is meant to be used ONLY to construct SELECT stmt for oracle
source.
For example, in oracle:
```
CREATE TABLE "t" ("iD" INT PRIMARY KEY, "AcC" INT)
```
We have to do
```
SELECT * FROM "t"
```
Otherwise we will encounter a "table doesn't exist" error.
Release note: None
ZhouXing19
force-pushed
the
encode-always-quoted
branch
from
4904abb to
bb3c0aa
Compare
|
Thanks! Closing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR won't merge with main but create a separate a new tag.
I set it to be merged against main just to enable code review.
To accomodate an oracle query, we need to quote the object name regardless if it is a reserved keyword or is bare identifier. This is because oracle is case insensitive without quotes. This flag is meant to be used ONLY to construct SELECT stmt for oracle source.
For example, in oracle:
We have to do
Otherwise we will encounter a "table doesn't exist" error.
Release note: None