Skip to content

Fix rejected sub-comments with code blocks overflowing #2819

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 10, 2025

Conversation

VasylMarchuk
Copy link
Collaborator

@VasylMarchuk VasylMarchuk commented May 4, 2025

Follow-up to #2780
Related to #1591

Brief

Additional tiny fix for rejected sub-comments with code blocks overflowing their allocated space.

Before

Знімок екрана 2025-05-04 о 11 40 20

After

Знімок екрана 2025-05-04 о 11 40 48

Test links

https://app.codecrafters.io/courses/http-server/stages/at4
https://frontend-git-another-comment-width-fix.ccio.dev/courses/http-server/stages/at4

Checklist

  • I've thoroughly self-reviewed my changes
  • I've added tests for my changes, unless they affect admin-only areas (or are otherwise not worth testing)
  • I've verified any visual changes using Percy (add a commit with [percy] in the message to trigger)

Summary by CodeRabbit

  • Style
    • Updated the styling of comment cards to apply a new layout class for comments that have a parent comment. Comments without a parent retain their previous appearance.

@VasylMarchuk VasylMarchuk added the bug Something isn't working label May 4, 2025
@VasylMarchuk VasylMarchuk requested a review from rohitpaulk May 4, 2025 08:58
@VasylMarchuk VasylMarchuk self-assigned this May 4, 2025
Copy link
Contributor

coderabbitai bot commented May 4, 2025

Walkthrough

The change updates the conditional logic for applying CSS classes to the root <div> of the comment card component. Now, when a comment has a parent, the min-w-0 class is applied to the <div>, whereas previously, no class was added in this case. If a comment does not have a parent, the existing classes bg-white dark:bg-gray-850 rounded remain in use. No changes were made to exported or public entities.

Changes

File Change Summary
app/components/comment-card/index.hbs Updated conditional logic for root <div> CSS classes: applies min-w-0 if comment has parent.

Possibly related PRs

Poem

In a burrow of code, so neat and so new,
A comment card dons a fresh CSS hue.
If parent is present, min-w-0 shines bright,
Alone, it stays rounded, cozy, and light.
Rabbits hop by, admiring the view—
Stylish comments for every crew!
🐇✨


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 9bc9996 and d2ee93d.

📒 Files selected for processing (1)
  • app/components/comment-card/index.hbs (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (1)
  • GitHub Check: test
🔇 Additional comments (1)
app/components/comment-card/index.hbs (1)

1-1: Good fix to prevent code blocks from overflowing!

Adding the min-w-0 class to child comments is an appropriate solution for the overflow issue. This class sets a minimum width of 0, which allows flex items to shrink below their content size if needed, preventing text and code blocks from overflowing their containers.

This change aligns perfectly with the PR's objective of fixing rejected comments with overflowing code blocks, and it's a standard approach for handling overflow in flexbox layouts.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

github-actions bot commented May 4, 2025

Test Results

  1 files  ±0    1 suites  ±0   7m 48s ⏱️ - 1m 30s
624 tests ±0  579 ✅ +1  45 💤 ±0  0 ❌ ±0 
624 runs  ±0  579 ✅ +2  45 💤 ±0  0 ❌  - 1 

Results for commit d2ee93d. ± Comparison against base commit 9bc9996.

Copy link

codecov bot commented May 4, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

@VasylMarchuk VasylMarchuk changed the title Fix rejected comments with code blocks overflowing Fix rejected sub-comments with code blocks overflowing May 4, 2025
@rohitpaulk
Copy link
Member

Nice catch!

@VasylMarchuk VasylMarchuk merged commit fa0abc8 into main May 10, 2025
8 of 9 checks passed
@VasylMarchuk VasylMarchuk deleted the another-comment-width-fix branch May 10, 2025 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants