Skip to content

Add option to skip interaction when using php artisan samlidp:cert #149

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

joelharkes
Copy link
Contributor

@joelharkes joelharkes commented Nov 13, 2024

We used to use the command php artisan samlidp:cert in a process, that did not have interactivity. The process would hanging because a question was asked.

Added

  • samlidp:cert --overwrite option to skip the question to overwrite cert files
  • samlidp:cert --subject to add subject name when generating certificates

@upwebdesign
Copy link
Contributor

@joelharkes I like this update. I trust this has been tested with multiple options?

@joelharkes
Copy link
Contributor Author

joelharkes commented Nov 18, 2024

let me write some unit tests to this, its better validation. i will add separate PR to add github action to run the unit tests :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants