Skip to content

Solidity version updated, refactoring and execute's input signatures need to be passed as v,r,s separate arrays anymore. #52

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

SuperCS92
Copy link

Hello, this project is really interesting. I would like to help to maintain the base code up to date. Following is a list of proposed changes with a brief explanation:

  • Input parameters uint8[] sigV, bytes32[] sigR, bytes32[] sigS, were replaced by a single array bytes [] memory sig, just to make it more user-friendly. Notice that the signatures are properly split with the internal splitSignature() method.
  • Refactor of execute method to separate responsibilities. recoverMulti() now handles the whole validation of signature process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant