-
Notifications
You must be signed in to change notification settings - Fork 0
feat: imperative infinite queries #6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -124,24 +124,27 @@ export class InfiniteQueryObserver< | |
> | ||
} | ||
|
||
fetchNextPage( | ||
options?: FetchNextPageOptions, | ||
): Promise<InfiniteQueryObserverResult<TData, TError>> { | ||
fetchNextPage({ pageParam, ...options }: FetchNextPageOptions = {}): Promise< | ||
InfiniteQueryObserverResult<TData, TError> | ||
> { | ||
return this.fetch({ | ||
...options, | ||
meta: { | ||
fetchMore: { direction: 'forward' }, | ||
fetchMore: { direction: 'forward', pageParam }, | ||
}, | ||
}) | ||
} | ||
|
||
fetchPreviousPage( | ||
options?: FetchPreviousPageOptions, | ||
): Promise<InfiniteQueryObserverResult<TData, TError>> { | ||
fetchPreviousPage({ | ||
pageParam, | ||
...options | ||
}: FetchPreviousPageOptions = {}): Promise< | ||
InfiniteQueryObserverResult<TData, TError> | ||
> { | ||
return this.fetch({ | ||
...options, | ||
meta: { | ||
fetchMore: { direction: 'backward' }, | ||
fetchMore: { direction: 'backward', pageParam }, | ||
}, | ||
}) | ||
} | ||
Comment on lines
+138
to
150
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Support for explicit pageParam added to fetchPreviousPage This change mirrors the update to The same type issue applies here - ensure that |
||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good update to support imperative infinite queries
The
fetchNextPage
method now accepts an optionalpageParam
property which enables users to explicitly control the pagination, aligning with the PR's objective to reintroduce imperative infinite queries functionality.A small issue to note: the pipeline shows a TypeScript error (TS2339) indicating that 'pageParam' doesn't exist on the
FetchNextPageOptions
type. The corresponding type definition should be updated.