Skip to content

Add sharing links to social sharing buttons #598

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: development
Choose a base branch
from
Open

Add sharing links to social sharing buttons #598

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/user/organization/popups/Members.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -202,9 +202,9 @@ class Members extends Component {
</div>
<div className="share__btn__container">
<p className="share__text">or share invite on</p>
<Button className="invite__btn">Facebook</Button>
<Button className="invite__btn">LinkedIn</Button>
<Button className="invite__btn">Twitter</Button>
<Button className="invite__btn" target = "_blank" style={{"padding-top":"6px"}} href={"https://www.facebook.com/sharer/sharer.php?u=" + inviteLink}>Facebook</Button>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @pranshukharkwal
Can you please add preview links in the form of cards when sharing?
cc @jaskiratsingh2000

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Rupeshiya
I am not exactly sure what you mean by preview links? Can you please explain? Or show an example?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I mean like when we use any link for sharing on LinkedIn or Twitter or any social media it shows the preview of the links. When we are sharing.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So you want preview for the Invite Link ( which would essentially be the Donut Homepage), or for the sharing link of that particular social media?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also I am thinking to use facebook graph API for link preview. What do you think? Should I go for it or you would suggest some other method?

<Button className="invite__btn" target = "_blank" style={{"padding-top":"6px"}} href={"https://www.linkedin.com/sharing/share-offsite/?url=" + inviteLink + "&title=&summary=&source="}>LinkedIn</Button>
<Button className="invite__btn" target = "_blank" style={{"padding-top":"6px"}} href={"https://twitter.com/intent/tweet?url=" + inviteLink + "&text=Checkout%20Donut.%20It%27s%20awesome"}>Twitter</Button>
</div>
</div>
</div>
Expand Down