Skip to content

Closes #68 - Add exceptions for missing PTR records #69

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Oct 10, 2017
Merged

Closes #68 - Add exceptions for missing PTR records #69

merged 4 commits into from
Oct 10, 2017

Conversation

codingo
Copy link
Owner

@codingo codingo commented Oct 10, 2017

Added exception handling around the DNS lookup to handle cases where PTR records may not be present, or a timeout occurs. Raise by @timkent in #68.

@codingo codingo requested a review from timkent October 10, 2017 04:03
@timkent
Copy link
Collaborator

timkent commented Oct 10, 2017 

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "VHostScan.py", line 127, in <module>
    main()
  File "VHostScan.py", line 96, in main
    except (dns.resolver.NXDOMAIN):
NameError: name 'dns' is not defined

@codingo
Copy link
Owner Author

codingo commented Oct 10, 2017

So that was a stupid transfer of code on my behalf! Not thinking at the time, patching this now.

@timkent
Copy link
Collaborator

timkent commented Oct 10, 2017

Looks good!

@timkent timkent closed this Oct 10, 2017
@timkent timkent reopened this Oct 10, 2017
timkent
timkent approved these changes Oct 10, 2017
View reviewed changes
Copy link
Collaborator

@timkent timkent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@timkent timkent merged commit 7697201 into master Oct 10, 2017
@codingo codingo deleted the codingo-dns-resolution-hotfix branch October 10, 2017 04:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timkent timkent timkent approved these changes

Assignees
No one assigned
Labels
enhancement hacktoberfest help wanted
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@codingo @timkent