Skip to content
This repository was archived by the owner on Oct 2, 2024. It is now read-only.

NNBD (non-nullable by default | null safety) #283

Merged
merged 7 commits into from
Apr 8, 2021
Merged

NNBD (non-nullable by default | null safety) #283

merged 7 commits into from
Apr 8, 2021

Conversation

vasilich6107
Copy link
Collaborator

@vasilich6107 vasilich6107 commented Apr 6, 2021

What does this PR do/solve?

NNBD migration

Superseeds #259

Closes #280 #13 #281 #279

@vasilich6107 vasilich6107 requested a review from comigor April 6, 2021 11:33
@vasilich6107 vasilich6107 force-pushed the nnbd branch 2 times, most recently from 49beeaf to 074ef2d Compare April 6, 2021 15:55
@@ -20,7 +17,7 @@ abstract class Name extends Equatable with DataPrinter {
final String name;

/// Instantiate a name.
Name({this.name}) : assert(hasValue(name));
const Name({required this.name}); // : assert(hasValue(name));

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
const Name({required this.name}); // : assert(hasValue(name));
const Name({required this.name});

@comigor
Copy link
Owner

comigor commented Apr 8, 2021

build_config and code_builder, as stated on comments, don't have a nullsafety version, but this shouldn't be an issue for users.

The same for build_runner and build_test dev_dependencies, in fact.

@comigor comigor changed the title Nnbd NNBD (non-nullable by default | null safety) Apr 8, 2021
Copy link
Owner

@comigor comigor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥳 🎉

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants