This repository was archived by the owner on Mar 23, 2021. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 33
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1fa15d3
to
69c4b5e
Compare
ready for review? |
Not yet, will announce when! |
D4nte
previously approved these changes
Aug 15, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I know it's WIP :)
.travis/clean-target-folder.sh
Outdated
|
||
ALL_WORKSPACE_CRATES=$(find vendor application -name Cargo.toml -exec toml --nocolor {} package.name \;) | ||
|
||
for CRATE in $ALL_WORKSPACE_CRATES; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[must] semi-colon is not needed thanks to the newline
.travis/clean-target-folder.sh
Outdated
do | ||
CRATE=$(echo "$CRATE" | tr -d '"') | ||
|
||
ARTIFCATS=$(find target/debug/deps -name "*$CRATE*") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[must] typo: ARTIFACTS
.travis/clean-target-folder.sh
Outdated
|
||
for ARTIFACT in $ARTIFCATS; | ||
do | ||
rm -rf $ARTIFACT |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[must] add double quotes
75d597e
to
b0c2cd6
Compare
We use sccache and synchronize its folder with our own VM. This greatly speeds up the builds!
13e3c97
to
a32f03a
Compare
bonomat
approved these changes
Aug 16, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Through the use of sccache and rsync, we can greatly speed up our builds!
We simply download the shared compilation cache from the VM before the build and upload the changes after the build. This takes not even 1 minute in total but greatly speeds up the build (only takes about 2 minutes then). In addition, the actual cache on Travis is much smaller and thus up- and downloaded faster!
Resolves #189.