Add Tags to blog posts #199
Conversation
- add tags to blog landing page - add tags to each post footer - each tag link to the tags page to the part where that tag is
- add blog-post-card in includes - fix multiple authors in blog-post-card
| @@ -120,7 +118,7 @@ increase my confidence as a developer in the LLVM open community! | |||
|
|
|||
| **Contact me!** | |||
|
|
|||
| Email: [email protected] | |||
| Email: <[email protected]> | |||
There was a problem hiding this comment.
Why did we have to change that?
There was a problem hiding this comment.
This will create a link for the email, which will open the user's default mail client with the specified "to" address. I think this will improve the overall user experience.
I can revert these changes if you want.
There was a problem hiding this comment.
I think we use this as an ID in other places and I'd prefer to not have that feature.
There was a problem hiding this comment.
Okay I'll revert these changes for emails.
There was a problem hiding this comment.
I think it would be enough if the link goes to the profile of the person instead of composing an email...
There was a problem hiding this comment.
Okay I'll make that change.
| @@ -120,7 +118,7 @@ increase my confidence as a developer in the LLVM open community! | |||
|
|
|||
| **Contact me!** | |||
|
|
|||
| Email: [email protected] | |||
| Email: [[email protected]](/team/MatheusIzvekov) | |||
There was a problem hiding this comment.
I meant that we should use the email as is without extra punctuation. In the blog-post-card.html or where the rendering happens we can turn it into a link.
There was a problem hiding this comment.
Eg you want to move the email to the page header? This seems like it is a free text field currently
There was a problem hiding this comment.
No, I do not want to have markdown style links or any other decoration around the email because that field is used (and will be used) as a unique ID for the people. Based on that we can make more advanced queries in the text files. That is why we should not decorate with more. Instead, we could move the decoration where it is needed - that is the blog post visualization...
There was a problem hiding this comment.
eg, something is grepping the markdown for the word Email?
There was a problem hiding this comment.
No, something makes a selection based on the email and/or author name across yml files. Or something could if we have a unique id. Pretty much how any relational database works.
There was a problem hiding this comment.
that makes sense.. but this is just some free text. So I don't understand the point.
There was a problem hiding this comment.
The point is that this free text can be used as a unique id.
There was a problem hiding this comment.
but you need to parse free text for that (so I guess the comment above is incorrect)...
Should not use the header information for that? (which does not make the life of the interested person viewing the page more difficult and could be used to make a contact form standard across posts..)
well it seems the correct action is to remove the part of the blog that is being discussed. The contact information is already at the top of the post. No need to repeat it.
There was a problem hiding this comment.
Wait, dammit.... I thought my comment was under the yaml file. Please ignore, now I can understand why what I was saying does not make any sense...
#196
/tagspage, allowing users to view all posts associated with a specific tag (e.g.,/tags/#gsoc)