Skip to content

Add announcement for closing numpy 2.0 migration #2522

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
May 28, 2025

Conversation

h-vetinari
Copy link
Member

For conda-forge/conda-forge-pinning-feedstock#7222, as discussed in a core call a while ago.

@h-vetinari h-vetinari requested a review from a team as a code owner May 17, 2025 05:58
Copy link

netlify bot commented May 17, 2025

Deploy Preview for conda-forge-previews ready!

Name Link
🔨 Latest commit ac8b88b
🔍 Latest deploy log https://app.netlify.com/projects/conda-forge-previews/deploys/68374e159de86200084d57b8
😎 Deploy Preview https://deploy-preview-2522--conda-forge-previews.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 50
Accessibility: 96
Best Practices: 100
SEO: 89
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify project configuration.

@h-vetinari
Copy link
Member Author

pre-commit.ci autofix

Copy link
Contributor

@hmaarrfk hmaarrfk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we add some of the comments I made in the news to the knowledge base?

Copy link
Member Author

@h-vetinari h-vetinari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the review!

Co-Authored-By: Mark Harfouche <[email protected]>
@h-vetinari
Copy link
Member Author

pre-commit.ci autofix

@h-vetinari
Copy link
Member Author

Ping for reviews @conda-forge/core

@h-vetinari h-vetinari merged commit 9f8392c into conda-forge:main May 28, 2025
6 checks passed
@h-vetinari
Copy link
Member Author

Thanks for the reviews @hmaarrfk & @jaimergp!

Copy link
Member

@jakirkham jakirkham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Axel! 🙏

This looks good

Had one small note. Sent a follow up PR for it


though the ongoing migration for numpy 2.0 has already been applied to many
feedstocks, in which case the pinning looks like
At the time of writing (June 2025), above is equivalent to the following,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Noted this says June whereas this was written in May

Admittedly this is probably splitting hairs this late in May. And it is very unlikely to change in June

Sent a small change to update: #2531

Ok either way

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants