-
-
Notifications
You must be signed in to change notification settings - Fork 291
Add announcement for closing numpy 2.0 migration #2522
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✅ Deploy Preview for conda-forge-previews ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
pre-commit.ci autofix |
for more information, see https://pre-commit.ci
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we add some of the comments I made in the news to the knowledge base?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the review!
Co-Authored-By: Mark Harfouche <[email protected]>
pre-commit.ci autofix |
for more information, see https://pre-commit.ci
Ping for reviews @conda-forge/core |
Co-authored-by: jaimergp <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Axel! 🙏
This looks good
Had one small note. Sent a follow up PR for it
|
||
though the ongoing migration for numpy 2.0 has already been applied to many | ||
feedstocks, in which case the pinning looks like | ||
At the time of writing (June 2025), above is equivalent to the following, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Noted this says June whereas this was written in May
Admittedly this is probably splitting hairs this late in May. And it is very unlikely to change in June
Sent a small change to update: #2531
Ok either way
For conda-forge/conda-forge-pinning-feedstock#7222, as discussed in a core call a while ago.